Repository navigation
Conversation
|
This is super exciting. Thanks for working on this. |
|
Wow, thank you! Please note it will probably take me a few weeks, due to my timetable, to fully review this. |
| } | ||
|
|
||
| // SrcMasterIsAlsoReplica is `true` when the master and replica is the same on source | ||
| func (this *MigrationContext) SrcMasterIsAlsoReplica() bool { |
There was a problem hiding this comment.
name SrcMasterIsAlsoReplica and DstMasterIsAlsoReplica are very strange,and "the master and replica is the same on source" not make sense。also "the master and replica is the same on destination"
There was a problem hiding this comment.
but names "src srcMaster dst dstMaster" is clear,i dont have better idea。
And fix for possible panic when getting binlog coordinates
|
|
||
| applierUri := this.connectionConfig.GetDBUri(this.migrationContext.DatabaseName) | ||
| if this.db, _, err = mysql.GetDB(this.migrationContext.Uuid, applierUri); err != nil { | ||
| srcApplierURI := this.srcConnectionConfig.GetDBUri(this.migrationContext.SrcDatabaseName) |
There was a problem hiding this comment.
srcApplierURI name should not contain "Applier",confirm to Inspector https://github.com/github/gh-ost/pull/565/files#diff-5aa50dde7ca1baf7a819eecf740ea220R51
| } | ||
|
|
||
| log.Infof("Creating changelog table %s.%s on src", | ||
| sql.EscapeName(this.migrationContext.DstDatabaseName), |
There was a problem hiding this comment.
this.migrationContext.DstDatabaseName seems should be this.migrationContext.SrcDatabaseName
It is based on #557
Related issue: #417
Description
This PR adds support for moving a table between different databases as well as different servers.
It's a feature complete version. And I'm working on tests/docs.