Repository navigation
Conversation
Contributor
|
Thank you! I'll be reviewing this PR in the next few days. |
Contributor
|
Please let me know when this will be ready for review (for sure I won't begin till next week) |
Author
|
It's ready for review now~ |
everpcpc
force-pushed
the
copy
branch
2 times, most recently
from
March 23, 2018 07:26
aa2b6eb to
74b35d8
Compare
Author
|
To make it clearer, I removed other changes and only left the managed rowcopy part. |
Contributor
|
Thank you! It's now a matter of setting serious time aside to review. |
everpcpc
force-pushed
the
copy
branch
3 times, most recently
from
April 28, 2018 08:04
3f6b79d to
14c185c
Compare
MOON-CLJ
reviewed
Apr 28, 2018
| if err != nil { | ||
| return nil, err | ||
| } | ||
| result, err := stmt.Exec(applyExplodedArgs...) |
Contributor
There was a problem hiding this comment.
what's the benefit to use prepare statement here? why the benefit to build a large query here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #91 #417
Description
This PR adds support for managed rowcopy.