Skip to content

Support managed rowcopy - #557

Closed
everpcpc wants to merge 3 commits into
github:masterfrom
everpcpc:copy
Closed

everpcpc wants to merge 3 commits into
github:masterfrom
everpcpc:copy

Conversation

@everpcpc

@everpcpc everpcpc commented Mar 6, 2018 •

Copy link
Copy Markdown

Related issue: #91 #417

Description

This PR adds support for managed rowcopy.

@shlomi-noach

Copy link
Copy Markdown
Contributor

Thank you! I'll be reviewing this PR in the next few days.

@shlomi-noach

Copy link
Copy Markdown
Contributor

Please let me know when this will be ready for review (for sure I won't begin till next week)

@everpcpc

everpcpc commented Mar 8, 2018

Copy link
Copy Markdown
Author

It's ready for review now~

@everpcpc
everpcpc force-pushed the copy branch 2 times, most recently from aa2b6eb to 74b35d8 Compare March 23, 2018 07:26
@everpcpc

everpcpc commented Mar 23, 2018 •

Copy link
Copy Markdown
Author

To make it clearer, I removed other changes and only left the managed rowcopy part.
It would be easier to review now~

@shlomi-noach

Copy link
Copy Markdown
Contributor

Thank you! It's now a matter of setting serious time aside to review.

@shlomi-noach
shlomi-noach changed the base branch from master to managed-rowcopy-contrib March 25, 2018 09:08
@shlomi-noach
shlomi-noach changed the base branch from managed-rowcopy-contrib to master March 25, 2018 09:51
@shlomi-noach shlomi-noach reopened this Mar 25, 2018
@shlomi-noach shlomi-noach mentioned this pull request Mar 25, 2018
@everpcpc
everpcpc force-pushed the copy branch 3 times, most recently from 3f6b79d to 14c185c Compare April 28, 2018 08:04
Comment thread go/logic/applier.go Outdated
if err != nil {
return nil, err
}
result, err := stmt.Exec(applyExplodedArgs...)

@MOON-CLJ MOON-CLJ Apr 28, 2018 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the benefit to use prepare statement here? why the benefit to build a large query here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants