Repository navigation
Allow users to input 2.x.y instead of v2.x.y - #7
Merged
Merged
Conversation
edoardopirovano
force-pushed
the
edoardo/short-input
branch
from
September 17, 2021 13:56
ea8f792 to
d7388f4
Compare
edoardopirovano
force-pushed
the
edoardo/short-input
branch
from
September 17, 2021 14:29
d7388f4 to
6596187
Compare
p0
suggested changes
Sep 17, 2021
p0
left a comment
p0
left a comment
Contributor
There was a problem hiding this comment.
As written, this breaks the nightly channel, where tags do not all start with v...
Contributor
Author
Does it? It's only changing the user's input if This does raise the important issue that there is no test coverage for downloading a nightly - let me add that in. |
p0
approved these changes
Sep 17, 2021
p0
left a comment
p0
left a comment
Contributor
There was a problem hiding this comment.
Oh, you're right, apologies. We'd better not introduce non-v* tags in the repo, then!
Co-authored-by: Pavel Avgustinov <54942558+p0@users.noreply.github.com>
p0
reviewed
Sep 17, 2021
p0
reviewed
Sep 17, 2021
Co-authored-by: Pavel Avgustinov <54942558+p0@users.noreply.github.com>
p0
approved these changes
Sep 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small UX improvement, I think a lot of users wouldn't know that the tags in our release repo are
v2.x.y, so if they just type in2.x.ywe should probably just add thevin for them -gh codeql set-version 2.5.9seems like the command a first-time user would naturally type, notgh codeql set-version v2.5.9.