Better error message for expired/invalid PAT #17

Activity

1. aeisenberg commented on Jan 25, 2022

   

   aeisenberg

   on Jan 25, 2022

   ContributorAuthor

   More actions

   Similar error with download.

   $ gh codeql  download 2.7.5
   expected an object but got: string ("https://docs.github.com/rest")
   ERROR: Version '2.7.5' not found.
   
2. edoardopirovano commented on Jan 25, 2022

   

   edoardopirovano

   on Jan 25, 2022

   Contributor

   More actions

   Hmm, everything is working fine for me and I can't seem to reproduce this locally. There must be something in your local environment that is different to mine (perhaps a Mac version of one of the utilities we are using that is doing something different from the Linux one?). I'd be happy to debug this together if you want to put a call in my calendar whenever suits you 🙂
3. aeisenberg commented on Jan 25, 2022

   

   aeisenberg

   on Jan 25, 2022

   ContributorAuthor

   More actions

   Interesting...let me play around a bit more. I'm using gh v2.4.0, which is the latest, so it's not that.
4. aeisenberg

   added

   bugSomething isn't workingSomething isn't working

   on Jan 25, 2022
5. edoardopirovano commented on Jan 25, 2022

   

   edoardopirovano

   on Jan 25, 2022

   Last edited by edoardopirovano

   Contributor

   More actions

   Incidentally, gh codeql download 2.7.5 does fail for me but with a different error (it wants gh codeql download v2.7.5 because the release tags have a v before them. I added some logic that automatically adds it when it's missing in set-version in #7 but apparently that logic isn't being used for download).
6. aeisenberg commented on Jan 25, 2022

   

   aeisenberg

   on Jan 25, 2022

   ContributorAuthor

   More actions

   🤦🏼 Looks like my PAT expired:

   $ gh api repos/github/codeql-cli-binaries/releases
   gh: Bad credentials (HTTP 401)
   {
     "message": "Bad credentials",
     "documentation_url": "https://docs.github.com/rest"
   }
   
7. edoardopirovano commented on Jan 25, 2022

   

   edoardopirovano

   on Jan 25, 2022

   Last edited by edoardopirovano

   Contributor

   More actions

   Aha, that would make sense. Still we could definitely recognise a 401 error and give the user a more informative error about renewing their PAT.
8. aeisenberg commented on Jan 25, 2022

   

   aeisenberg

   on Jan 25, 2022

   ContributorAuthor

   More actions

   That would be nice. I got a message that it expired today, but completely forgot about it.

   I'll update the issue title.
9. aeisenberg

   changed the title [-]List versions is giving an error[/-] [+]Better error message for expired/invalid PAT[/+] on Jan 25, 2022
10. aeisenberg

    added

    enhancementNew feature or requestNew feature or request

    and removed

    bugSomething isn't workingSomething isn't working

    on Jan 25, 2022