Skip to content

Added fix to replace escaped html entities in <pre> elements with literal character. - #740

Closed
sciencemanx wants to merge 1 commit into
git:masterfrom
sciencemanx:html-escaping
Closed

sciencemanx wants to merge 1 commit into
git:masterfrom
sciencemanx:html-escaping

Conversation

@sciencemanx

Copy link
Copy Markdown

Fix from issue #645 (@Peter-Liang). The code runs on document ready to replace the wrongly escaped entities within <pre> elements.

Example affected page: https://git-scm.com/book/en/v2/Git-Basics-Undoing-Things#Unmodifying-a-Modified-File

@peff

peff commented May 3, 2016

Copy link
Copy Markdown
Member

I believe this probably does help in most cases, but it's a pretty nasty hack. Besides requiring JS for something that really shouldn't need it, it may also hit false positives when things are supposed to be encoded at &gt;. So I'd rather avoid merging this if we can come up with some better solution, like getting the upstream content fixed, or even rendering the progit content ourselves instead of pulling the pre-made HTML from Atlas (which is defunct as of March 2016, anyway).

@sxlijin

sxlijin commented Feb 14, 2017

Copy link
Copy Markdown
Contributor

@peff can this be closed, since the referenced issues are now fixed upstream?

@peff

peff commented Feb 14, 2017

Copy link
Copy Markdown
Member

Yeah, I think this is stale now. #755 put a similar hack into the import process, but I think even that is probably obsolete now since #917, which skips Atlas entirely.

@peff peff closed this Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants