You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interesting. Doubly so because that chapter doesn't actually seem to be translated in the Italian version, meaning that it is ultimately coming from the same source in progit/progit2.
It looks like git-scm.com ultimately gets its Pro Git content by downloading a pre-built HTML ebook. Pulling that down manually, it looks like the damage is already done there; it has <code> tags referring to & gt;. So the breakage is somewhere in the progit build toolchain, but I don't know how that works. /cc @schacon and @ben
It is weird that the English version is broken but the Italian one isn't. Looking at the db records, it seems that our URL for the Italian version is from 2015-08-10, whereas the English one is from 2016-03-22. So maybe something simply changed in the progit toolchain between those times, and if the Italian one were rebuilt today, it would be similarly broken.
My guessing:
Once each language repository of progit2 has a new commit pushed, it will trig Atlas to auto build somethings, including HTML book. (see progit2 tanslations and progit2 issue 585)
@YueLinHo pointed out that this is indeed a bug in upstream progit, and is being tracked in progit/progit2#371. I'm going to keep this open as tracking for the issue, even though there's really not a good fix on the git-scm.com side.
Activity
peff commentedon May 2, 2016
Interesting. Doubly so because that chapter doesn't actually seem to be translated in the Italian version, meaning that it is ultimately coming from the same source in progit/progit2.
It looks like git-scm.com ultimately gets its Pro Git content by downloading a pre-built HTML ebook. Pulling that down manually, it looks like the damage is already done there; it has
<code>tags referring to& gt;. So the breakage is somewhere in the progit build toolchain, but I don't know how that works. /cc @schacon and @benIt is weird that the English version is broken but the Italian one isn't. Looking at the db records, it seems that our URL for the Italian version is from 2015-08-10, whereas the English one is from 2016-03-22. So maybe something simply changed in the progit toolchain between those times, and if the Italian one were rebuilt today, it would be similarly broken.
YueLinHo commentedon May 3, 2016
My guessing:
Once each language repository of progit2 has a new commit pushed, it will trig Atlas to auto build somethings, including HTML book. (see progit2 tanslations and progit2 issue 585)
peff commentedon May 3, 2016
@YueLinHo pointed out that this is indeed a bug in upstream progit, and is being tracked in progit/progit2#371. I'm going to keep this open as tracking for the issue, even though there's really not a good fix on the git-scm.com side.
peff commentedon May 3, 2016
More discussion in #645, and a possible workaround in #740.
jnavila commentedon May 3, 2016
We could patch this when importing the book from atlas into the db. I'll look into the rake script.
postprocess book v2 for entities in code blocks
postprocess book v2 for entities in code blocks
styfle commentedon May 6, 2016
Looks good! Thanks 💯