Skip to content

Code blocks rendering html entities #753

Closed

Description

@styfle

Compare these two pages:

The en page is showing code blocks incorrectly, for example:

PS> tf history $/myproject -recursive > AUTHORS_TMP

The it page is showing the code blocks as expected, for example:

PS> tf history $/myproject -recursive > AUTHORS_TMP

Activity

  1. peff commented on May 2, 2016

    @peff
    Member

    Interesting. Doubly so because that chapter doesn't actually seem to be translated in the Italian version, meaning that it is ultimately coming from the same source in progit/progit2.

    It looks like git-scm.com ultimately gets its Pro Git content by downloading a pre-built HTML ebook. Pulling that down manually, it looks like the damage is already done there; it has <code> tags referring to &amp gt;. So the breakage is somewhere in the progit build toolchain, but I don't know how that works. /cc @schacon and @ben

    It is weird that the English version is broken but the Italian one isn't. Looking at the db records, it seems that our URL for the Italian version is from 2015-08-10, whereas the English one is from 2016-03-22. So maybe something simply changed in the progit toolchain between those times, and if the Italian one were rebuilt today, it would be similarly broken.

  2. YueLinHo commented on May 3, 2016

    @YueLinHo

    My guessing:
    Once each language repository of progit2 has a new commit pushed, it will trig Atlas to auto build somethings, including HTML book. (see progit2 tanslations and progit2 issue 585)

  3. peff commented on May 3, 2016

    @peff
    Member

    @YueLinHo pointed out that this is indeed a bug in upstream progit, and is being tracked in progit/progit2#371. I'm going to keep this open as tracking for the issue, even though there's really not a good fix on the git-scm.com side.

  4. peff commented on May 3, 2016

    @peff
    Member

    More discussion in #645, and a possible workaround in #740.

  5. jnavila commented on May 3, 2016

    @jnavila
    Contributor

    We could patch this when importing the book from atlas into the db. I'll look into the rake script.

  6. added 2 commits that reference this issue on May 3, 2016
    d49b648
    55f679f
  7. styfle commented on May 6, 2016

    @styfle
    Author

    Looks good! Thanks 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions