Repository navigation
test(e2e): Remove unused dependencies from E2E test apps - #26231
Merged
Merged
Conversation
Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
Contributor
size-limit report 📦Compared: 51ba728 (PR test merge using develop at 1d354fd) Against: 1d354fd (develop) · base run #65483 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 not successful, 20 successful. See the run.
Successful checks
|
The Sentry Mastra integration loads it at runtime to bootstrap the observability pipeline, so it is used even though the app never imports it.
mydea
marked this pull request as ready for review
November 10, 2026 10:32
mydea
requested review from
andreiborza,
chargome,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
November 10, 2026 10:32
…d-deps-e2e # Conflicts: # dev-packages/e2e-tests/test-applications/node-eve/package.json # dev-packages/e2e-tests/test-applications/node-pi-durable/package.json
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Many test apps install packages that nothing imports or runs. Most are leftovers from project templates, such as jest and supertest in Nest apps, karma in Angular apps, ESLint packages in apps with no ESLint config, and vitest helpers with no unit tests. Others are old workarounds. They make installs slower and give Dependabot more to bump. Every removal is a package.json change only.
How to review: Groups worth a closer look:
import-in-the-middleandrequire-in-the-middlein the Next 16 apps and nextjs-otlp. test(nextjs): Add next@16 e2e test #17922 added them as a Turbopack/pnpm workaround. No SDK package depends on them or on@opentelemetry/instrumentationanymore, and neither do these apps. CI is the real check here.isbot: removed only from React Router apps whose ownentry.serverdoesn't use it. Apps without anentry.serverkeep it, because the default one imports it.lintscripts in create-remix-app-express(-vite-dev) and remix-hydrogen were removed too; without a config they already failed.ts-loader, because webpack mode needs it. nestjs-12 also drops@nestjs/testing@latestfrom itstest:build-latestscript.@babel/plugin-proposal-decoratorsin the Cloudflare agent apps:agentsalready depends on it.Unsure about: Ember apps were not changed, because ember-cli loads addons from package.json without any import. Some dependencies are left in for now:
@astrojs/internal-helpers, nitro-3rolldown, nuxt-5db0, and the@types/*packages the build type-checks against.Checks run: oxfmt only. I didn't run the E2E apps locally because they need the packed tarballs, so this relies on CI.
Related: the same cleanup for the workspace packages is in its own PR.
via Francesco Gringl-Novy.
--
View Session [Sentry]