Repository navigation
test(nextjs): Add next@16 e2e test - #17922
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
RulaKhaled
approved these changes
Oct 14, 2025
logaretm
approved these changes
Oct 14, 2025
andreiborza
pushed a commit
to thedanchez/sentry-javascript
that referenced
this pull request
Oct 15, 2025
- adds a new next 16 test - removes canary testing for app dir and pages dir tests (this is becoming too cumbersome to maintain across canary/bundler versions etc. – will instead move these tests into next 16 going forward) Note that next@canary will now always resolve to next@16
This was referenced Oct 15, 2025
This was referenced Nov 1, 2025
1 task
This was referenced Nov 5, 2025
This was referenced Nov 15, 2025
1 task
1 task
This was referenced Nov 28, 2025
This was referenced Dec 9, 2025
This was referenced Dec 17, 2025
mydea
added a commit
that referenced
this pull request
Nov 10, 2026
**Why:** Many test apps install packages that nothing imports or runs. Most are leftovers from project templates, such as jest and supertest in Nest apps, karma in Angular apps, ESLint packages in apps with no ESLint config, and vitest helpers with no unit tests. Others are old workarounds. They make installs slower and give Dependabot more to bump. Every removal is a package.json change only. **How to review:** Groups worth a closer look: - `import-in-the-middle` and `require-in-the-middle` in the Next 16 apps and nextjs-otlp. #17922 added them as a Turbopack/pnpm workaround. No SDK package depends on them or on `@opentelemetry/instrumentation` anymore, and neither do these apps. CI is the real check here. - `isbot`: removed only from React Router apps whose own `entry.server` doesn't use it. Apps without an `entry.server` keep it, because the default one imports it. - ESLint: removed from apps that have no ESLint config. The `lint` scripts in create-remix-app-express(-vite-dev) and remix-hydrogen were removed too; without a config they already failed. - nestjs-webpack keeps `ts-loader`, because webpack mode needs it. nestjs-12 also drops `@nestjs/testing@latest` from its `test:build-latest` script. - `@babel/plugin-proposal-decorators` in the Cloudflare agent apps: `agents` already depends on it. **Unsure about:** Ember apps were not changed, because ember-cli loads addons from package.json without any import. Some dependencies are left in for now: `@astrojs/internal-helpers`, nitro-3 `rolldown`, nuxt-5 `db0`, and the `@types/*` packages the build type-checks against. **Checks run:** oxfmt only. I didn't run the E2E apps locally because they need the packed tarballs, so this relies on CI. Related: the same cleanup for the workspace packages is in its own PR. <!-- junior-request-attribution:start --> via **Francesco Gringl-Novy**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AD0CA8FXFXAS%3A1794301479.516639 --> -- [View Session](https://junior-prod.sentry.dev/conversations/slack%3AD0CA8FXFXAS%3A1794301479.516639) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AD0CA8FXFXAS%3A1794301479.516639/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Francesco Gringl-Novy <francesco.novy@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that next@canary will now always resolve to next@16