Repository navigation
Formatted address - #522
Closed
n-sviridenko wants to merge 1 commit into
Closed
n-sviridenko wants to merge 1 commit into
n-sviridenko wants to merge 1 commit into
Conversation
n-sviridenko
force-pushed
the
feature/formatted-address
branch
from
August 19, 2016 18:11
a3226cb to
f37ab76
Compare
n-sviridenko
force-pushed
the
feature/formatted-address
branch
from
August 19, 2016 20:37
f37ab76 to
a6df761
Compare
Author
|
Also, you can create a compatibility table for each provider and each ability. It will warn users. |
Member
|
Hey @n-sviridenko There has been a lots of changes in master since you made this PR. There is now a custom Google response where this change should be added. Can you rebase this PR and make sure you add the changes to the GoogleAddress instead of the shared one? This PR is no longer on hold. |
Member
|
Closed by #655 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I'm understanding that you declined this feature. But despite the fact that this parameter isn't common, it's very useful for the localization, because we don't have a good php library for address localization yet. I'm sure that most of people are using google maps provider and also they're using this parameter. And it will be better to use your solution instead of writing own just for one property.
If you are not agree, would you please to add a raw response data of the providers?
Thank you for avance!