Add support for formatted address #558

Activity

1. Nyholm

   added this to the 4.0.0 milestone on Dec 22, 2016
2. fyrye commented on Feb 6, 2017

   

   fyrye

   on Feb 6, 2017

   More actions

   One suggestion to this would be to also allow the retrieval of responses from the providers, rather than just extracting the information in the executeQuery method.

   Then a user would be able to extend a Provider object and instead of being forced to override the executeQuery method they could parse the response as desired with their own method.

   For example:

   $adapter  = new \Http\Adapter\Guzzle6\Client();
   $geocoder = new \Geocoder\Provider\GoogleMaps($adapter);
   
   $geocoder->geocode(...);
   $jsonResponse = $geocoder->getRepsonse(); //formatted address is available here

   public function geocode($address)
   {
      $query = $address;
      //...
      return $this->parseData($this->executeQuery($query));
   }
   
   public function getResponse()
   {
       return $this->response;
   }
   
   private function parseData($content)
   {
       //...
      return $this->resultResults($results);
   }
   
   protected function executeQuery($query)
   {
       $query = $this->buildQuery($query);
       if (!$this->response = json_encode((string) $this->getAdapter()->get($query)->getBody())) {
           throw new NoResult(sprintf('Could not execute query "%s".', $query));
       }
       //... move parsing of data out of executeQuery
   
       return $this->response;
   }
3. Nyholm commented on May 30, 2017

   

   Nyholm

   on May 30, 2017

   MemberAuthor

   More actions

   Closed by #655
4. Nyholm

   closed this as completedon May 30, 2017