Repository navigation
[camera_android_camerax] Update skills_lint to 0.5.3 - #13530
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the camera_android_camerax package's skills configuration and validation. It marks the pre-push-skill as internal, upgrades skills_lint to version 0.5.3, expands the lint rules in skills_lint.yaml, and adds a check in validate_skills_test.dart to verify that the configuration parses successfully. No review comments were provided, so there is no additional feedback.
reidbaker
approved these changes
Nov 2, 2026
1 task done
camsim99
approved these changes
Nov 2, 2026
jpohhhh
pushed a commit
to Telosnex/flutter
that referenced
this pull request
Nov 4, 2026
…r#195977) flutter/packages@1df8447...670b30e 2026-11-04 36861262+QuncCccccc@users.noreply.github.com [material_ui] Inherit `IconButtonThemeData.variant` from enclosing themes (flutter/packages#13263) 2026-11-04 katelovett@google.com [tool] Regenerate `MockGitDir` for `package:git` 2.5.0 (flutter/packages#13544) 2026-11-03 hkarmoush@gmail.com [material_ui] Fix discrete Slider selecting the neighboring tick near the track ends (flutter/packages#12927) 2026-11-03 32538273+ValentinVignal@users.noreply.github.com [material_ui] Migrate M3 Time Picker template to use new gen_defaults (flutter/packages#13164) 2026-11-03 269567208+reidbaker-agent@users.noreply.github.com [camera_android_camerax] Update skills_lint to 0.5.3 (flutter/packages#13530) 2026-11-03 engine-flutter-autoroll@skia.org Roll Flutter from fcfb4f2 to 9347202 (38 revisions) (flutter/packages#13540) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to skills_lint 0.5.3 and enable new configs for published skills.
Along the way we found that a skill was not being limited.
@reidbaker
Details
Updates the `skills_lint` dev dependency from `^0.5.1` to `^0.5.3` and turns on more checks in `skills_lint.yaml`:skills/directory:pub-archive-includes-skill(reports a skill or linked file thatdart pub publishwould leave out) andcheck-relative-pathswithwithin-skill: true(reports relative links that leave the skill directory).skills/has only a README today, so these guard future skills.skills/:published-skill-name, which checks thepackage:skillsnaming convention (added in 0.5.2).check-absolute-pathsanddisallowed-field. Both rules already existed before 0.5.3.disallowed-fieldchecks theSKILL.mdfrontmatter keys..agents/skills/pre-push-skillas internal (metadata: internal: true) and lists it underindividual_skillswithprevent-skills-sh-publishing, the same way ascheck-readiness.test/validate_skills_test.dartnow checksexpect(config.parsingErrors, isEmpty). The 0.5.3 CHANGELOG notes thatvalidateSkillsreturnstrueeven whenconfig.parsingErrorsis not empty, so a typo inskills_lint.yaml(for example, an unknown rule name) would otherwise pass the test.This is a dev-only change: it touches a dev dependency, the lint config, a dev skill and a test, with no change to the published plugin. It needs the
override: no versioning neededandoverride: no changelog neededlabels, as #12684 (the previous skills_lint bump) used, because theversion-checktool does not treatpubspec.yamlandskills_lint.yamlas dev-only paths.No issue tracks this routine dependency update, so this PR does not link one.
I prepared this change with help from an AI agent and reviewed it.
Local checks, against skills_lint 0.5.3 from pub.dev:
flutter testpasses (includingtest/validate_skills_test.dart),dart run skills_lintexits 0, and the repo tool'sformat,analyze,license-checkandpublish-checkreport no issues.validate --check-for-missing-changespasses when given the two override labels above.Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2