Skip to content

[camera_android_camerax] Update skills_lint to 0.5.3 - #13530

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
reidbaker-agent:ds-pr-camerax
Nov 3, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:mainfrom
reidbaker-agent:ds-pr-camerax

Conversation

@reidbaker-agent

@reidbaker-agent reidbaker-agent commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Update to skills_lint 0.5.3 and enable new configs for published skills.
Along the way we found that a skill was not being limited.

@reidbaker

Details Updates the `skills_lint` dev dependency from `^0.5.1` to `^0.5.3` and turns on more checks in `skills_lint.yaml`:
  • New in 0.5.3, for the published skills/ directory: pub-archive-includes-skill (reports a skill or linked file that dart pub publish would leave out) and check-relative-paths with within-skill: true (reports relative links that leave the skill directory). skills/ has only a README today, so these guard future skills.
  • Also for skills/: published-skill-name, which checks the package:skills naming convention (added in 0.5.2).
  • For all skills: check-absolute-paths and disallowed-field. Both rules already existed before 0.5.3. disallowed-field checks the SKILL.md frontmatter keys.
  • Marks .agents/skills/pre-push-skill as internal (metadata: internal: true) and lists it under individual_skills with prevent-skills-sh-publishing, the same way as check-readiness.
  • test/validate_skills_test.dart now checks expect(config.parsingErrors, isEmpty). The 0.5.3 CHANGELOG notes that validateSkills returns true even when config.parsingErrors is not empty, so a typo in skills_lint.yaml (for example, an unknown rule name) would otherwise pass the test.

This is a dev-only change: it touches a dev dependency, the lint config, a dev skill and a test, with no change to the published plugin. It needs the override: no versioning needed and override: no changelog needed labels, as #12684 (the previous skills_lint bump) used, because the version-check tool does not treat pubspec.yaml and skills_lint.yaml as dev-only paths.

No issue tracks this routine dependency update, so this PR does not link one.

I prepared this change with help from an AI agent and reviewed it.

Local checks, against skills_lint 0.5.3 from pub.dev: flutter test passes (including test/validate_skills_test.dart), dart run skills_lint exits 0, and the repo tool's format, analyze, license-check and publish-check report no issues. validate --check-for-missing-changes passes when given the two override labels above.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the camera_android_camerax package's skills configuration and validation. It marks the pre-push-skill as internal, upgrades skills_lint to version 0.5.3, expands the lint rules in skills_lint.yaml, and adds a check in validate_skills_test.dart to verify that the configuration parses successfully. No review comments were provided, so there is no additional feedback.

@reidbaker reidbaker added CICD Run CI/CD override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Nov 2, 2026
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2026
@auto-submit
auto-submit Bot merged commit dae4525 into flutter:main Nov 3, 2026
13 checks passed
jpohhhh pushed a commit to Telosnex/flutter that referenced this pull request Nov 4, 2026
…r#195977)

flutter/packages@1df8447...670b30e

2026-11-04 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Inherit `IconButtonThemeData.variant` from enclosing themes
(flutter/packages#13263)
2026-11-04 katelovett@google.com [tool] Regenerate `MockGitDir` for
`package:git` 2.5.0 (flutter/packages#13544)
2026-11-03 hkarmoush@gmail.com [material_ui] Fix discrete Slider
selecting the neighboring tick near the track ends
(flutter/packages#12927)
2026-11-03 32538273+ValentinVignal@users.noreply.github.com
[material_ui] Migrate M3 Time Picker template to use new gen_defaults
(flutter/packages#13164)
2026-11-03 269567208+reidbaker-agent@users.noreply.github.com
[camera_android_camerax] Update skills_lint to 0.5.3
(flutter/packages#13530)
2026-11-03 engine-flutter-autoroll@skia.org Roll Flutter from
fcfb4f2 to 9347202 (38 revisions) (flutter/packages#13540)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants