Repository navigation
[camera_android_camerax] Update skills_lint to published version ^0.5.1 - #12684
Merged
auto-submit[bot] merged 1 commit intoAug 28, 2026
Merged
Conversation
- Update pubspec.yaml to depend on published skills_lint: ^0.5.1 - Verify skill validation tests pass cleanly
reidbaker
added
override: no versioning needed
reidbaker
approved these changes
Aug 28, 2026
reidbaker-agent
marked this pull request as ready for review
August 28, 2026 21:20
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the skills_lint dev dependency in packages/camera/camera_android_camerax/pubspec.yaml from a git-based dependency to a hosted version constraint (^0.5.1). There are no review comments, and I have no feedback to provide.
reidbaker
added
the
autosubmit
pull Bot
pushed a commit
to fucheng-guo-sun/flutter
that referenced
this pull request
Aug 31, 2026
flutter/packages@cd4cdd0...d642322 2026-08-30 engine-flutter-autoroll@skia.org Roll Flutter from 8d8c1aa to c978386 (20 revisions) (flutter/packages#12693) 2026-08-28 katelovett@google.com [ci] Update labeler (flutter/packages#12636) 2026-08-28 269567208+reidbaker-agent@users.noreply.github.com [camera_android_camerax] Update skills_lint to published version ^0.5.1 (flutter/packages#12684) 2026-08-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 6b182d2 to d3b14c8 (1391 revisions) (flutter/packages#12678) 2026-08-28 269567208+reidbaker-agent@users.noreply.github.com [camera_android_camerax] Add presubmit sweep, cross-platform paths, and test diff guidelines to AGENTS.md (flutter/packages#12668) 2026-08-28 engine-flutter-autoroll@skia.org Roll Flutter from e8dca90 to 8d8c1aa (27 revisions) (flutter/packages#12679) 2026-08-28 dkwingsmt@users.noreply.github.com [cupertino_ui, material_ui] Use range matchers instead of exact positions in scroll tests (flutter/packages#12664) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
….1 (flutter#12684) TBH the agent authored description is pretty spot on. - @reidbaker Agent authored description --- Migrates the \`camera_android_camerax\` package skill validation dependency from Git to the published [\`skills_lint: ^0.5.1\`](https://pub.dev/packages/skills_lint) package on pub.dev. - Updates \`packages/camera/camera_android_camerax/pubspec.yaml\` to depend on \`skills_lint: ^0.5.1\`. - Verified with \`flutter pub get\` and \`flutter test\`.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
….1 (flutter#12684) TBH the agent authored description is pretty spot on. - @reidbaker Agent authored description --- Migrates the \`camera_android_camerax\` package skill validation dependency from Git to the published [\`skills_lint: ^0.5.1\`](https://pub.dev/packages/skills_lint) package on pub.dev. - Updates \`packages/camera/camera_android_camerax/pubspec.yaml\` to depend on \`skills_lint: ^0.5.1\`. - Verified with \`flutter pub get\` and \`flutter test\`.
9 of 11 tasks
auto-submit Bot
pushed a commit
that referenced
this pull request
Nov 3, 2026
Update to skills_lint 0.5.3 and enable new configs for published skills. Along the way we found that a skill was not being limited. @reidbaker <details> Updates the `skills_lint` dev dependency from `^0.5.1` to `^0.5.3` and turns on more checks in `skills_lint.yaml`: * New in 0.5.3, for the published `skills/` directory: `pub-archive-includes-skill` (reports a skill or linked file that `dart pub publish` would leave out) and `check-relative-paths` with `within-skill: true` (reports relative links that leave the skill directory). `skills/` has only a README today, so these guard future skills. * Also for `skills/`: `published-skill-name`, which checks the `package:skills` naming convention (added in 0.5.2). * For all skills: `check-absolute-paths` and `disallowed-field`. Both rules already existed before 0.5.3. `disallowed-field` checks the `SKILL.md` frontmatter keys. * Marks `.agents/skills/pre-push-skill` as internal (`metadata: internal: true`) and lists it under `individual_skills` with `prevent-skills-sh-publishing`, the same way as `check-readiness`. * `test/validate_skills_test.dart` now checks `expect(config.parsingErrors, isEmpty)`. The 0.5.3 CHANGELOG notes that `validateSkills` returns `true` even when `config.parsingErrors` is not empty, so a typo in `skills_lint.yaml` (for example, an unknown rule name) would otherwise pass the test. This is a dev-only change: it touches a dev dependency, the lint config, a dev skill and a test, with no change to the published plugin. It needs the `override: no versioning needed` and `override: no changelog needed` labels, as #12684 (the previous skills_lint bump) used, because the `version-check` tool does not treat `pubspec.yaml` and `skills_lint.yaml` as dev-only paths. No issue tracks this routine dependency update, so this PR does not link one. I prepared this change with help from an AI agent and reviewed it. Local checks, against skills_lint 0.5.3 from pub.dev: `flutter test` passes (including `test/validate_skills_test.dart`), `dart run skills_lint` exits 0, and the repo tool's `format`, `analyze`, `license-check` and `publish-check` report no issues. `validate --check-for-missing-changes` passes when given the two override labels above. </details> ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBH the agent authored description is pretty spot on.
Agent authored description
Migrates the `camera_android_camerax` package skill validation dependency from Git to the published `skills_lint: ^0.5.1` package on pub.dev.