Repository navigation
[material_ui] Make SearchAnchor.bar respect SearchBarThemeData padding - #13360
Merged
auto-submit[bot] merged 2 commits intoNov 5, 2026
Merged
Conversation
github-actions
Bot
added
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates SearchAnchor.bar to fallback to SearchBarThemeData.padding when barPadding is null, and adds a corresponding regression test. The review feedback suggests migrating the deprecated MaterialStatePropertyAll to WidgetStatePropertyAll in the updated padding fallback code.
QuncCccccc
approved these changes
Nov 5, 2026
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for porting it over!
QuncCccccc
force-pushed
the
fix-search-anchor-theme-padding
branch
from
November 5, 2026 01:00
0560124 to
eec51eb
Compare
QuncCccccc
added
CICD
bkonyi
pushed a commit
to bkonyi/flutter
that referenced
this pull request
Nov 5, 2026
…er#196047) flutter/packages@670b30e...0478162 2026-11-05 mkmt@google.com [material_ui] Document RefreshIndicator mouse behavior on desktop and web (flutter/packages#13286) 2026-11-05 45147003+samar70@users.noreply.github.com [material_ui] Make SearchAnchor.bar respect SearchBarThemeData padding (flutter/packages#13360) 2026-11-04 kevmoo@users.noreply.github.com [pointer_interceptor] Use dart.library.js_interop in example export (flutter/packages#13558) 2026-11-04 louisehsu@google.com [in_app_purchase_storekit] Use purchase(confirmIn:) for StoreKit 2 purchases (flutter/packages#13410) 2026-11-04 41366638+kirya355@users.noreply.github.com [material_ui] Fix dismissal near minimum extent when shouldCloseOnMinExtent (flutter/packages#12545) 2026-11-04 36861262+QuncCccccc@users.noreply.github.com [material_ui] Add Material 3 Expressive `ElevatedButton` (flutter/packages#13084) 2026-11-04 108947675+IbrarIlyas@users.noreply.github.com [go_router] Stop inactive StatefulShellRoute branches from vetoing pops (flutter/packages#12972) 2026-11-04 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from abaf9c5 to c197ca5 (14 revisions) (flutter/packages#13542) 2026-11-04 stuart.morgan@gmail.com [in_app_purchase] Convert example app to Swift (flutter/packages#13556) 2026-11-04 fluttergithubbot@gmail.com Sync release-go_router-18.1.3 to main (flutter/packages#13559) 2026-11-04 fluttergithubbot@gmail.com Sync release-material_ui-1.10.0 to main (flutter/packages#13546) 2026-11-04 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Add magic number guideline to `TESTING.md` (flutter/packages#13081) 2026-11-04 fluttergithubbot@gmail.com Sync release-cupertino_ui-1.1.6 to main (flutter/packages#13547) 2026-11-04 stuartmorgan@google.com [file_selector] Convert unit tests to Kotlin (flutter/packages#13102) 2026-11-04 engine-flutter-autoroll@skia.org Roll Flutter from 9347202 to 3623d2d (25 revisions) (flutter/packages#13555) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#185889
Ports flutter/flutter#186037. Part of flutter/flutter#188444.
Makes
SearchAnchor.baruseSearchBarThemeData.paddingwhenbarPaddingis null.cc @CoderBoxer
I used AI assistance to port the approved fix.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2