Repository navigation
[material_ui] Document RefreshIndicator mouse behavior on desktop and web - #13286
Conversation
… web Adds a troubleshooting section explaining why mouse drags and mouse wheel scrolling don't trigger RefreshIndicator on desktop and web, and how to support mouse users. Fixes flutter/flutter#135510
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the |
github-actions
Bot
added
p: material_ui
triage-design
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation to RefreshIndicator explaining why it does not respond to mouse gestures on desktop and web by default, and details how to enable mouse support. It also adds a corresponding changelog entry. There are no review comments, and I have no feedback to provide.
bf9ebe8 to
72a2ce7
Compare
|
This PR only changes doc comments, plus a pending changelog entry, so I believe it qualifies for a test exemption ("only affect comments (including documentation)" in Tree Hygiene. |
elliette
left a comment
elliette
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me. I agree this PR is test exempt.
…er#196047) flutter/packages@670b30e...0478162 2026-11-05 mkmt@google.com [material_ui] Document RefreshIndicator mouse behavior on desktop and web (flutter/packages#13286) 2026-11-05 45147003+samar70@users.noreply.github.com [material_ui] Make SearchAnchor.bar respect SearchBarThemeData padding (flutter/packages#13360) 2026-11-04 kevmoo@users.noreply.github.com [pointer_interceptor] Use dart.library.js_interop in example export (flutter/packages#13558) 2026-11-04 louisehsu@google.com [in_app_purchase_storekit] Use purchase(confirmIn:) for StoreKit 2 purchases (flutter/packages#13410) 2026-11-04 41366638+kirya355@users.noreply.github.com [material_ui] Fix dismissal near minimum extent when shouldCloseOnMinExtent (flutter/packages#12545) 2026-11-04 36861262+QuncCccccc@users.noreply.github.com [material_ui] Add Material 3 Expressive `ElevatedButton` (flutter/packages#13084) 2026-11-04 108947675+IbrarIlyas@users.noreply.github.com [go_router] Stop inactive StatefulShellRoute branches from vetoing pops (flutter/packages#12972) 2026-11-04 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from abaf9c5 to c197ca5 (14 revisions) (flutter/packages#13542) 2026-11-04 stuart.morgan@gmail.com [in_app_purchase] Convert example app to Swift (flutter/packages#13556) 2026-11-04 fluttergithubbot@gmail.com Sync release-go_router-18.1.3 to main (flutter/packages#13559) 2026-11-04 fluttergithubbot@gmail.com Sync release-material_ui-1.10.0 to main (flutter/packages#13546) 2026-11-04 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Add magic number guideline to `TESTING.md` (flutter/packages#13081) 2026-11-04 fluttergithubbot@gmail.com Sync release-cupertino_ui-1.1.6 to main (flutter/packages#13547) 2026-11-04 stuartmorgan@google.com [file_selector] Convert unit tests to Kotlin (flutter/packages#13102) 2026-11-04 engine-flutter-autoroll@skia.org Roll Flutter from 9347202 to 3623d2d (25 revisions) (flutter/packages#13555) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adds a "Refresh indicator does not respond to a mouse" section to the
RefreshIndicatortroubleshooting docs. It explains that:ScrollBehavior.dragDevicesdoesn't includePointerDeviceKind.mouse.RefreshIndicatorState.show, or addPointerDeviceKind.mousetoScrollBehavior.dragDevices(with a code example and a note about the text-selection trade-off).This is a documentation-only change (test-exempt) with no behavior changes. It adds a pending changelog entry (
version: patch).Fixes flutter/flutter#135510
%23%23 Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the %23hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2