Repository navigation
Fix long byte decoder input position for nonzero offsets - #74
Merged
Merged
Conversation
The byte-array decoder scans with an absolute index that already starts at inpos, then added that index to the original offset. A nonzero offset was applied twice, and a zero-length decode moved a nonzero cursor. Store the absolute end position, matching the int byte decoders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LongVariableByte.uncompress(byte[])has the same cursor bug as the int byte decoders in #73. The scan indexpalready starts atinpos.get(), andinpos.add(p)applies a nonzero offset a second time. Decoding a four-byte block that starts at 1 leaves the cursor at 6 instead of 5, so the next block is read from the wrong place. A zero-length decode also moves a nonzero cursor (5 becomes 10).Store the absolute end position with
inpos.set(p). Offset 0 is unchanged, becausepfinishes atinlength. Thelong[]compress and uncompress paths already advance by a length, not by an absolute index.The new tests fail on the old
inpos.add(p)(expected:<5> but was:<6>for a four-byte block at offset 1, andexpected:<5> but was:<10>for an empty decode).mvn testpasses: 105 tests, 1 existing skip.