Repository navigation
Fix byte decoder input positions for nonzero offsets - #73
Merged
Merged
Conversation
Signed-off-by: Jaehong Park <105151063+PHJ2000@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a byte-array block starts at a nonzero input offset, VariableByte and IntegratedVariableByte add the final absolute cursor to the original offset. For example, decoding a four-byte block starting at 1 leaves the cursor at 6 instead of 5, so the next block is read from the wrong location. A zero-length decode also changes a nonzero cursor.
Set the input position to the final cursor in both decoders. Extend the existing nonzero-offset round-trip test to check both cursors and add an empty-input regression.
Validation: the regressions fail before the fix;
mvn packagepasses (104 tests, 1 existing skip), and the example compiles and runs on Java 21.