Repository navigation
[Improve Concept Exercise] : inventory-management (dicts) #2342
Description
This issue is for improvements & changes needed to the inventory-management concept exercise on the Python track.
Goals
Improve the Inventory-management (dicts) concept exercise by adding the dict.pop() method & creation via dict literal to the tasks the student has to complete. Make other improvement changes as noted below:
- Edit
design.mddoc to adddict.pop()to the design - Edit
Introduction.mdto adddict.pop()usage. - Edit
instructions.mdto add new tasks:
- creation ofdictliterals
- usingdict.pop() - Add appropriate hint as needed in
hints.mdfordict.pop()usage - Edit
exemplar.pyto include new idiomatic solution for newly added tasks - Edit
dicts_test.pyfile to add new tests fordict.pop()task. - Edit
dicts.pystub file to add new tasks. - Edit test file to explicitly list imported functions/methods by name instead of using
import * - Check/edit all markdown files to conform to the Exercism Markdown Specifications
Getting started
Please please please read the docs before starting. Posting PRs without reading these docs will be a lot more frustrating for you during the review cycle, and exhaust Exercism's maintainers' time. So, before diving into the implementation, please read up on the following documents:
Activity
[-] Improve Concept Exercise: inventory-management[/-][+][V3] Improve Concept Exercise: inventory-management[/+]github-actions commentedon Mar 10, 2021
This issue has been automatically marked as
abandoned 🏚because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.github-actions commentedon Apr 1, 2021
This issue has been automatically marked as
abandoned 🏚because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.14 remaining items
mukeshgurpude commentedon Sep 2, 2021
Is this task still unfinished?
BethanyG commentedon Sep 2, 2021
Hi @mukeshgurpude 👋🏽 This task is indeed unfinished. I was in the middle of it when we went to launch, so I have a half finished PR. I'd love some help, if you'd like to join in? Just let me know, and I can flag it as [claimed] for you.
mukeshgurpude commentedon Sep 3, 2021
I would like to help on this task. I would start working on this task later in the day.
Could you please update the links about Markdown style guides in Issue description, they are giving me 404 now🤔.
BethanyG commentedon Sep 3, 2021
The task is all yours! And thank you for taking it on! 🌟
I am going to go ahead and PR what I have and flag it as a draft. You should then be able to make commits to it. Or not. Your choice! You can also start over from the top, if you prefer. 😄
Yes. Apologies! All the links should now be updated to go to the nicely formatted website docs. LMK if you have additional questions or issues. I should be available until midnight pacific.
BethanyG commentedon Sep 3, 2021
The draft PR is here: #2530
mukeshgurpude commentedon Sep 7, 2021
Hello @BethanyG. Since there is already a pull request from your fork to the upstream, I thought of pushing changes to your fork only..
I've opened a pull request BethanyG#15, but maybe you missed it by chance..
BethanyG commentedon Sep 7, 2021
@mukeshgurpude -- Oh no! I *did miss it! 😱 so sorry. I will take a look right now. Thanks!
mukeshgurpude commentedon Sep 7, 2021
@BethanyG as related PR is merged, we should close this issue now.
BethanyG commentedon Sep 7, 2021
@mukeshgurpude -- thank you for the reminder! 😂 I have one too many things to do, and forgot this.