[mukeshgurpude]

Since, there's already a draft pull request from this branch, I thought about just pushing changes to this branch only.

• Edit design.md doc to add dict.pop() to the design

• Edit Introduction.md to add dict.pop() usage.

• Edit instructions.md to add new tasks:

  • creation of dict literals (not needed. See comments)
  • using dict.pop()

• Add appropriate hint as needed in hints.md for dict.pop() usage

• Edit exemplar.py to include new idiomatic solution for newly added tasks

• Edit dicts_test.py file to add new tests for dict.pop() task.

• Edit dicts.py stub file to add new tasks.

• Edit test file to explicitly list imported functions/methods by name instead of using import *

• Check/edit all markdown files to conform to the Exercism Markdown Specifications

[mukeshgurpude]

Edit instructions.md to add new tasks:

• creation of dict literals
• using dict.pop()

I didn't got the idea of instructing about creation of dict literals.
Can you please elaborate on this task?

[BethanyG]

I didn't got the idea of instructing about creation of dict literals.
Can you please elaborate on this task?

This was referring to teaching a student that they can call the constructor (dict()) -- but can also use the literal declaration ({}) when they don't need the overhead of the constructor. -- That the substantial difference is that dict() will unpack, and the literal will not. Screen grab below from the docs on dict().. but we do NOT have to cover all of these by any means.

We are teaching comprehensions in a separate exercise.

🤔 Wondering now as I re-read this if we really need a specific exercise task for creating a dict literal vs constructor. I think as long as we have the differences outlined in the introduction.md and the about.md, the student will be able to understand they can use {} OR dict() interchangeably in many/most circumstances.

Worst case scenario is that we will need to do another change farther down the line to the exercise. But that is OK. 😄 These are all works in progress!

Thoughts? For you as a learner, would practicing the difference between {} and dict() be important, or am I making too much of that?

[BethanyG]

I think we may also want to revise the wording and function name on task number three, to make a distinction between decrementing inventory counts vs removing the item (and all counts) from the inventory (which is your new task #4).

Suggest something like:

3. Decrement stock in the inventory

Implement the decrement_items(<items>) function that takes a list of items. The function should remove one from the available count in the inventory for each time an item appears on the list:

decrement_items({"coal":3, "diamond":1, "iron":5}, ["diamond", "coal", "iron", "iron"])
{"coal":2, "diamond":0, "iron":3}

Item counts in the inventory should not fall below 0. If the number of times an item appears on the list exceeds the count available, the quantity listed for that item should remain at 0 and additional requests for removing counts should be ignored.

delete_items({"coal":2, "wood":1, "diamond":2}, ["coal", "coal", "wood", "wood", "diamond"])
{"coal":0, "wood":0, "diamond":1}

---

Of course that also means that the exemplar.py, stub, and test file will need to be updated. Apologies for that.

[BethanyG]

Hi @mukeshgurpude -- Thank you for all the work on this. 🌟 Apologies for all the delays in reviewing it.

Overall, this looks pretty good! I did have some language suggestions, and an additional thought on task 3 re-wording.

This PR is also failing CI -- I think that's due to some upstream changes from today that you didn't get the chance to pull in. If you can, please do that. If you can't -- we can merge this into my original branch, and resolve the issue there.

[BethanyG]

Sigh. GitHub got me again. I meant to request changes, but it went ahead and "approved". Again, I think the changes are straightforward and should be quick.

[mukeshgurpude]

Wondering now as I re-read this if we really need a specific exercise task for creating a dict literal vs constructor. I think as long as we have the differences outlined in the introduction.md and the about.md, the student will be able to understand they can use {} OR dict() interchangeably in many/most circumstances.

That's why I think, there is no need to talk about dict literals and constructor in Instructions, but we have to add that in Introduction section, which is already Done.

I think we may also want to revise the wording and function name on task number three, to make a distinction between decrementing inventory counts vs removing the item (and all counts) from the inventory (which is your new task #4).

I'll do that

[BethanyG]

That's why I think, there is no need to talk about dict literals and constructor in Instructions, but we have to add that in Introduction section, which is already Done.

Agree. Let's leave that particular change off. 😄 I will go ahead and wait for that last task 3 change, and then we can merge this in! YAY!

[BethanyG]

Awesome! 🌟 This looks good to go. Many thanks!

[mukeshgurpude]

Awesome! 🌟 This looks good to go. Many thanks!

I'm looking forward to contribute more in Exercism!!🥲