Skip to content

Enable NO_PROXY environment variable support - #835

Merged
florimondmanca merged 4 commits into
encode:masterfrom
evanlurvey:master
Mar 2, 2020
Merged

florimondmanca merged 4 commits into
encode:masterfrom
evanlurvey:master

Conversation

@evanlurvey

Copy link
Copy Markdown
Contributor

This PR addresses issue #360. I found this issue by attempting to use httpx in a environment that had both endpoints that needed to be proxied and ones that needed to stay in the local network. That is when I found out that there was no "NO_PROXY" support.

@florimondmanca florimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice catch, thank you! ✨

A little cosmetic suggestion for the test from me.

Comment thread tests/client/test_proxies.py Outdated
Comment thread tests/client/test_proxies.py Outdated
@florimondmanca florimondmanca added proxies Issues related to HTTP and SOCKS proxies enhancement New feature or request labels Feb 29, 2020
evanlurvey and others added 2 commits February 29, 2020 21:27
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>

@florimondmanca florimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@florimondmanca
florimondmanca merged commit 707e54c into encode:master Mar 2, 2020
@lovelydinosaur lovelydinosaur mentioned this pull request Mar 5, 2020
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
Bumps [black](https://github.com/psf/black) from 23.7.0 to 23.10.1.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@23.7.0...23.10.1)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request proxies Issues related to HTTP and SOCKS proxies

Development

Successfully merging this pull request may close these issues.

2 participants