Repository navigation
Add support for the NO_PROXY environment variable #360
Description
The NO_PROXY environment variable is described here:
- http://www.gnu.org/software/wget/manual/html_node/Proxies.html
- https://github.com/psf/requests/blob/840540b6b1f07ef87faab73392c03fbef0dcc9fe/requests/utils.py#L395
In order to accomplish this task we'd need:
- Implementing NO_PROXY, a list of hosts that will bypass the proxy if found within the list.
- Only enabled if
trust_env=True - Documentation updates for the new environment variable.
- Test cases for all code branches.
Activity
elwinmartin commentedon Sep 19, 2019
@sethmlarson Hi Seth!
I would love to work on this if I could!
I'm mostly familiar with this library as a user but I think the context provided should be clear enough to adapt this for httpx.
sethmlarson commentedon Sep 19, 2019
That would be awesome!! I'll assign the issue to you :)
If you have questions or doubts feel free to reach out here and we'll try our best to help.
lovelydinosaur commentedon Sep 27, 2019
Looks good.
Related to #404. I wonder if cURL would be a good baseline set of environment variables to adhere too? That's probably more robust and mature than any other tooling out there, so I'd be okay with us explicitly following their lead.
mariaS210 commentedon Oct 6, 2019
@sethmlarson hello! is someone working on this? if not, i'd like to try it
florimondmanca commentedon Oct 6, 2019
Feel free to go ahead @mariaS210! 🎉
yeraydiazdiaz commentedon Nov 4, 2019
Closed via #471
lovelydinosaur commentedon Jan 14, 2020
Reopening this, since it's evidently been closed in error - #471 adds
NO_PROXYhandling utility functions, but doesn't tie it in to the client.pawamoy commentedon Jan 20, 2020
Is there another way to bypass the proxies while waiting for
NO_PROXYto be tied into the client?lovelydinosaur commentedon Jan 20, 2020
You can use
trust_env=Falseto disable system proxies.https://www.python-httpx.org/environment_variables/
evanlurvey commentedon Feb 29, 2020
I have addressed this in #835
evanlurvey commentedon Mar 2, 2020
@florimondmanca Would you want to close this issue now?