Repository navigation
Make client.cookies setter expect a Cookies instance - #678
Closed
florimondmanca wants to merge 1 commit into
Closed
florimondmanca wants to merge 1 commit into
florimondmanca wants to merge 1 commit into
Conversation
florimondmanca
commented
Dec 21, 2019
| def cookies(self, cookies: CookieTypes) -> None: | ||
| self._cookies = Cookies(cookies) | ||
| def cookies(self, cookies: Cookies) -> None: | ||
| self._cookies = cookies |
Contributor
Author
There was a problem hiding this comment.
@tomchristie Would we want to add an assert or any kind of runtime type check here? I'm not sure it's really needed.
Also, this change makes the cookies property equivalent to a simple variable, so we might as well switch it to just that — a plain and public .cookies variable?
Member
|
I think we should probably only do this if we're also doing the same for |
Contributor
Author
|
Closing this one for now to be addressed later with a pass on |
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
Preserves the exception chain instead of displaying "During handling of the above exception, another exception occurred" in the traceback Co-authored-by: Tom Christie <tom@tomchristie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by #677 (comment)
@tomchristie IMO the only thing that does look odd (at least from a typing perspective) is the setter magic, so this PR focuses on that. In particular, not sure we really want to get rid of
CookieTypesand change thecookiesparameters to prevent using the conveniencedict/CookieJartypes.