Repository navigation
Type-check test_cookies.py - #677
Conversation
|
|
||
| client = Client(dispatch=MockDispatch()) | ||
| client.cookies = cookies | ||
| client.cookies = cookies # type: ignore |
There was a problem hiding this comment.
mypy doesn't yet support setters that accept arguments of a different type than what is returned by the getter. The official recommandation is to # type: ignore for now. See: python/mypy#3004
There was a problem hiding this comment.
Hrm. Well, it is a strange usage. Got me thinking that maybe we just shouldn鈥檛 be doing that in the first place...
Instead, we could enforce this style:
client.cookies = httpx.Cookies(...)
That鈥檚 possibly less surprising than setting the cookies to a dict, but having it return a Cookies instance.
We would probably want to hard check the type.
Obvs same would apply to the other setters too.
Thoughts?
There was a problem hiding this comment.
Yup, sure, that would sound good to me. :-)
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Looks good. Going to suggest that we defer a decision on client.cookies, client.headers, client.params setters at this point in time.
More tests type-checking, refs #650.