Skip to content

Repository navigation

Include URL.__hash__ in test - #64

Merged
lovelydinosaur merged 4 commits into
encode:masterfrom
yeraydiazdiaz:test-url-hash
May 15, 2019
Merged

Include URL.__hash__ in test#64
lovelydinosaur merged 4 commits into
encode:masterfrom
yeraydiazdiaz:test-url-hash

Conversation

@yeraydiazdiaz

@yeraydiazdiaz yeraydiazdiaz commented May 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Increasing the test coverage #26 ever so slightly.

@yeraydiazdiaz yeraydiazdiaz mentioned this pull request May 14, 2019
Closed
@lovelydinosaur

lovelydinosaur commented May 14, 2019

Copy link
Copy Markdown
Member

I鈥檇 probably:

  1. Add a test to models/test_url instead of test_request.
  2. Test that URL instances can used in a set, rather than testing hash directly. (Since that鈥檚 the actual behaviour we care about here)

@lovelydinosaur

lovelydinosaur commented May 15, 2019

Copy link
Copy Markdown
Member

Ace!

@lovelydinosaur
lovelydinosaur merged commit 2e9ab2e into encode:master May 15, 2019
@yeraydiazdiaz
yeraydiazdiaz deleted the test-url-hash branch May 15, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yeraydiazdiaz @lovelydinosaur