added netrc support by cansarigol · Pull Request #177 · encode/httpx

cansarigol · 2019-07-30T13:51:28Z

No description provided.

sethmlarson · 2019-07-30T16:53:35Z

    """

-    def __init__(self, *, cert: CertTypes = None, verify: VerifyTypes = True):
+    def __init__(


Let's revert usages of trust_env for SSLConfig. The default behavior in the future should be use system trust stores unless we're specifically told which cert bundle to use.

Although this change reminded me to create another issue for SSL_CERT_... environment variables.

You're right new approach for environment variables would be nice.
I reverted the last commit.

sethmlarson

So the whole trust_env parameter is kind of a can of worms. Ian, Cory, and @nateprewitt have all dealt with it and there are large issue threads i can dig up about all the issues.

The biggest issue is basically we're going to be embedded into applications/tools that don't expose a way to control how we configure ourselves but users still need to configure us for proxies, authentication, certificates, etc. I think the best way to achieve that is still environment variables but then you get into priorities like "both REQUESTS_CA_CERT and SSL_CERT_FILE ste defined and are different, what do we do?"

We need answers to these questions for sure, maybe a variable that can control order?

lovelydinosaur

Looks really good yeah! 👍
Feel questions and comments for ya.

lovelydinosaur · 2019-07-31T13:45:39Z

    return None
+
+
+def get_netrc_login(url: str) -> typing.Union[typing.Tuple[str, str, str], None]:


Signature should either be host or authority here, right?
It's not clear to me from a glance at the netrc docs, which of those two is actually the correct thing to use?
Also we should prefer typing.Optional[typing.Tuple[str, str, str]] as the return annotation.

machine in the config. I changed it as host I can change again if necessary

lovelydinosaur · 2019-07-31T13:46:59Z

+
+def get_netrc_login(url: str) -> typing.Union[typing.Tuple[str, str, str], None]:
+    try:
+        _netrc = netrc.netrc(os.environ.get("DEFAULT_NETRC_PATH"))  # type: ignore


I'd probably prefer a variable name that's not underscore prefixed here. netrc_info maybe?

Is DEFAULT_NETRC_PATH a standardized thing? (Or used by requests or something?)

I made it up to explain the initial path.

I'm pretty sure NETRC is the env variable to specify the path

lovelydinosaur · 2019-07-31T13:47:21Z

@@ -0,0 +1,3 @@
+machine test_entrc.httpx.com


Let's use the example.org domain, since it's there for this sort of thing.

If appropriate, I used netrcexample.org. Because some tests are affected by example.org.

lovelydinosaur · 2019-07-31T13:49:10Z

@@ -0,0 +1,3 @@
+machine test_entrc.httpx.com
+login tomchristie
+password password123


I'd probably marginally prefer that we use a fake style username here example-username and example-password or something. Just feels marginally cleaner.

cansarigol · 2019-07-31T16:44:40Z

Thanks, I applied your comments.

StephenBrown2 · 2019-07-31T18:13:10Z

    assert response.json() == {"auth": "Token 123"}
+
+
+def test_entrc_auth():


Typo: entrc -> netrc

thanks, fixed

sethmlarson

I've got no issue with this current implementation.

lovelydinosaur · 2019-08-01T08:35:26Z

Great stuff, thanks!
Opening up two other issues that would act as further enhancements to this.

cansarigol mentioned this pull request Jul 30, 2019

Environment support #33

Closed

sethmlarson reviewed Jul 30, 2019

View reviewed changes

sethmlarson suggested changes Jul 30, 2019

View reviewed changes

cansarigol force-pushed the netrc branch from 9e21295 to b349b5a Compare July 30, 2019 17:32

lovelydinosaur requested changes Jul 31, 2019

View reviewed changes

cansarigol force-pushed the netrc branch from b349b5a to 05b3a11 Compare July 31, 2019 16:43

cansarigol force-pushed the netrc branch from 05b3a11 to 2543814 Compare July 31, 2019 18:04

cansarigol pushed a commit to cansarigol/httpx that referenced this pull request Jul 31, 2019

added netrc support encode#177

2543814

StephenBrown2 reviewed Jul 31, 2019

View reviewed changes

added netrc support

247d6d9

cansarigol force-pushed the netrc branch from 2543814 to 247d6d9 Compare July 31, 2019 18:18

sethmlarson approved these changes Jul 31, 2019

View reviewed changes

sethmlarson requested a review from lovelydinosaur July 31, 2019 23:16

lovelydinosaur approved these changes Aug 1, 2019

View reviewed changes

lovelydinosaur merged commit 919e8d3 into encode:master Aug 1, 2019

This was referenced Aug 1, 2019

Support .trust_env attribute on the client instance. #185

Closed

Try both ~/.netrc and ~/_netrc files #186

Closed

This was referenced May 11, 2026

Environment support pydantic/httpx2#15

Closed

Support .trust_env attribute on the client instance. pydantic/httpx2#61

Closed

Try both ~/.netrc and ~/_netrc files pydantic/httpx2#62

Closed

teamleaderleo mentioned this pull request Jul 30, 2026

[Fieldwork] Characterize sync response close failure state teamleaderleo/httpx#2

Draft

		return None


		def get_netrc_login(url: str) -> typing.Union[typing.Tuple[str, str, str], None]:

		assert response.json() == {"auth": "Token 123"}


		def test_entrc_auth():

Conversation

cansarigol commented Jul 30, 2019

Uh oh!

sethmlarson Jul 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sethmlarson left a comment

Choose a reason for hiding this comment

Uh oh!

lovelydinosaur left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cansarigol Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cansarigol commented Jul 31, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sethmlarson left a comment

Choose a reason for hiding this comment

Uh oh!

lovelydinosaur commented Aug 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

sethmlarson Jul 30, 2019 •

edited

Loading

cansarigol Jul 31, 2019 •

edited

Loading