Repository navigation
Environment support #33
Description
Needs to handle anything that requests currently deals with when trust_env=True is set.
.netrc, REQUEST_CA_BUNDLE and anything else relevant.
First step to dealing with this would be to outline exactly what set of stuff requests includes. If anyone wants to dig into this and comment on this issue comprehensively with what set of behavior we need, then that'd be a great start.
We have adapters/environment.py currently stubbed out to deal with adding in this behavior.
Activity
[-]Environment support.[/-][+]Environment support[/+]jhtimmins commentedon Jul 24, 2019
If this is still important, I'd be interested in doing some research here to determine what exactly requests includes, and then possibly implementing proper functionality.
sethmlarson commentedon Jul 24, 2019
This is definitely important! If you can lend a hand with discovery that'd be great.
cansarigol commentedon Jul 30, 2019
Hi, I tried to include netrc support. #177 what do you think about this approach?
sethmlarson commentedon Aug 17, 2019
We still need a way to grab environment variables and to document those environment variables for this issue to be closed.
florimondmanca commentedon Aug 26, 2019
I did some research in the Requests docs looking for environment variables it supports, and whether we support them already:
NETRCREQUEST_CA_BUNDLEorCURL_CA_BUNDLE(see here and here).HTTP_PROXY,HTTPS_PROXY(see here),ALL_PROXY,NO_PROXY.(Note that the names of the
*_PROXYenvironment variables seems be a convention.)To make extra sure we don't miss anything, it would probably be worth cloning the Requests repo and grepping our way using
environment variable,os.getenvandos.environ.get.The scope of this issue is rather broad, so if that's confirmed and as suggested by @sethmlarson in #277 (comment), how about creating issues for each set of environment variables?
sethmlarson commentedon Aug 27, 2019
Should also support
SSL_CERT_FILEas that's merged in Requests 3.0 branch and was intended to be supported and is an OpenSSL thing. See PEP 476.florimondmanca commentedon Aug 30, 2019
After inspecting the Requests code base, I updated the list with
CURL_CA_BUNDLE— I couldn't find any other use of environment variables in there.jlaine commentedon Aug 30, 2019
Having recently spent a lot of time in wireshark, I'd quite like
SSLKEYLOGFILEtoo (unless Python'ssslprovides this free of charge?)florimondmanca commentedon Aug 30, 2019
Seems it will be landing in Python 3.8. Meanwhile, sslkeylog?