Skip to content

Support HTTPS proxies. #722

Closed
Closed

Description

@lovelydinosaur

Of the following proxy cases...

  • HTTP proxy + HTTP destination
  • HTTP proxy + HTTPS destination
  • HTTPS proxy + HTTP destination
  • HTTPS proxy + HTTPS destination

...we currently only support the first two.

In order to support the other two cases we should add a proxy_ssl_context argument, which should be used for the SSL connection to the proxy itself.

Implementing the last case will be a little complicated for the sync case, since the stdlib wrap_socket behaviour doesn't support TLS-in-TLS.

Note that the urllib3 project documentation, do a good job of documenting the possible proxy types.

Also see the httpx issue for this... encode/httpx#1434


Progress...

  • Supported in standard sync.
  • Supported in asyncio.
  • Supported in trio.

Activity

  1. lovelydinosaur commented on Jun 14, 2023

    @lovelydinosaur
    MemberAuthor

    I think that closing #721 is a necessary precursor to resolving this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions