Tests for network backends. #721

Activity

1. lovelydinosaur

   added

   testsTests & coverageTests & coverage

   on Jun 14, 2023
2. karpetrosyan commented on Jun 16, 2023

   

   karpetrosyan

   on Jun 16, 2023

   Contributor

   More actions

   I'd suggest that we start just by implementing some test cases for the first of those, with tests for each of...

   Should we use real connections or mock the underlying socket?
3. lovelydinosaur commented on Jun 16, 2023

   

   lovelydinosaur

   on Jun 16, 2023

   MemberAuthor

   More actions

   No sure. I'd assumed that we'd need to work with real sockets for these tests, I don't think we can mock it out without monkey-patching right?
4. karpetrosyan commented on Jun 16, 2023

   

   karpetrosyan

   on Jun 16, 2023

   Contributor

   More actions

   That's a little complicated, but it solves a lot of problems.
   This is very similar to the "network_backend" argument.

   _Address: typing.TypeAlias = typing.Tuple[typing.Optional[str], int]
   
   class SocketInterface(Protocol):
   
       def send(self, data: bytes) -> int: ...
   
       def sendall(self, data: bytes) -> None: ...
   
       def recv(self, bufsize: int) -> bytes: ...
   
       @typing.overload
       def setsockopt(self, level: int, optname: int, value: typing.Union[int, bytes]) -> None: ...
       @typing.overload
       def setsockopt(self, level: int, optname: int, value: None, optlen: int) -> None: ...
   
       def settimeout(self, value: typing.Union[float, None]) -> None: ...
   
       def close(self) -> None: ...
   
   class SocketFactory:
       def create_connection(
               self,
               addr: _Address,
               timeout: typing.Optional[float] = None,
               source_address: typing.Optional[_Address] = None
       ) -> SocketInterface:
           return socket.create_connection(addr, timeout, source_address)
   
   class SyncBackend(NetworkBackend):
       def connect_tcp(
           self,
           host: str,
           port: int,
           timeout: typing.Optional[float] = None,
           local_address: typing.Optional[str] = None,
           socket_options: typing.Optional[typing.Iterable[SOCKET_OPTION]] = None,
           socket_factory: typing.Optional[SocketFactory] = None
       ) -> NetworkStream:
           # Note that we automatically include `TCP_NODELAY`
           # in addition to any other custom socket options.
           if socket_options is None:
               socket_options = []  # pragma: no cover
           address = (host, port)
           source_address = None if local_address is None else (local_address, 0)
           exc_map: ExceptionMapping = {
               socket.timeout: ConnectTimeout,
               OSError: ConnectError,
           }
   
           if socket_factory is None:
               socket_factory = SocketFactory()
   
           with map_exceptions(exc_map):
               sock = socket_factory.create_connection(
                   address,
                   timeout,
                   source_address=source_address,
               )
               for option in socket_options:
                   sock.setsockopt(*option)  # pragma: no cover
               sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
           return SyncStream(sock)
5. karpetrosyan commented on Jun 16, 2023

   

   karpetrosyan

   on Jun 16, 2023

   Contributor

   More actions

   But it'll be too complicated because we'll need different interfaces for the socket and trio/anyio bytestreams, as well as different factories for these streams, so I think it'd be better to just test with real connections.
6. lovelydinosaur commented on Sep 1, 2023

   

   lovelydinosaur

   on Sep 1, 2023

   MemberAuthor

   More actions

   I don't think we've sufficient motivation to treat this as a hard issue right now. This is maybe worth us covering, but I'm going to bump it down to a discussion. If it's valuable we ought to have a "what is this resolving for us, and is it worth the cost it brings".
7. encode

   locked and limited conversation to collaborators on Sep 1, 2023
8. lovelydinosaur

   converted this issue into a discussion #793 on Sep 1, 2023