Repository navigation
native-modules: check every module shares its dependency versions - #4635
jeff-hykin wants to merge 13 commits into
Conversation
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 18c24f7 | Previous: 4bee180 | Ratio |
|---|---|---|---|
peak memory |
1588.223 MB |
1566.871 MB |
1.01 |
peak threads |
360 threads |
364 threads |
0.99 |
network (transport) |
2722.098 MB |
2730.605 MB |
1.00 |
disk write |
1.469 MB |
1.449 MB |
1.01 |
instructions |
115.376 G |
115.402 G |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
…leases like semver
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4635 +/- ##
==========================================
- Coverage 81.76% 81.73% -0.04%
==========================================
Files 1641 1641
Lines 153507 153507
Branches 12933 12933
==========================================
- Hits 125511 125464 -47
- Misses 24428 24467 +39
- Partials 3568 3576 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…per-module exceptions
| @@ -0,0 +1,205 @@ | |||
| { | |||
There was a problem hiding this comment.
Later PR removes a TON of these exceptions.
- This PR is merely the checker.
- Follow-up PR is actually forcing modules to share.
[Medium impact] Adds a dependency-version consistency check to the build pipeline. The missing regression tests are a non-blocking concern; the executed comparison cases passed, and no merge-blocking failure was established. Findings
SummaryAdds One non-blocking concern remains: the repository has no focused tests for the new comparison rules. The 18 dependency-independent native-module tests passed without calling the checker. Six separate probes covering versions, features, and exceptions passed, demonstrating that these regression tests can run without Nix. No blocking issue was established.
PR #4636 could not be read because fetching its supplied revision failed with HTTP 429, so this assessment does not assume it fixes anything.
Reviews (1) · Last reviewed commit: "native-modules: print the exact fix for ..." · Reviewed by Greptile |
Adds
bin/native-modules --check-shared-deps(CI + pre-commit), failing when native modules lock or build a shared flake input, nix package or crate differently; today's mismatches are listed as exceptions for follow-up PRs to remove.