[jxs1211]

Signed-off-by: xian-jie.shen 327411586@qq.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

• I have read through the CONTRIBUTING.md documentation.
• My code has the necessary comments and documentation (if needed).
• I have added relevant tests

Description

Maybe there is an OOM risk in this code, so try to fix it.

Related Issues

see #833 for the details

New Behavior (screenshots if needed)

• add an defer for closing the file:
  

• add a ut for the funcion:

[going@dev md5]$ go tool cover -func=coverage.out
github.com/devstream-io/devstream/pkg/util/md5/helper.go:11:    CalcFileMD5     90.0%
github.com/devstream-io/devstream/pkg/util/md5/md5.go:12:       FileMatchesMD5  75.0%
total:                                                          (statements)    83.3%

[jxs1211]

@HXCGIT the TestCase in the help_test.go maybe fail, because the case needs a test file to exist in the same directory, but don't commit the test file is more reasonable, do you have any better idea for this situation.

[steinliber]

@HXCGIT the TestCase in the help_test.go maybe fail, because the case needs a test file to exist in the same directory, but don't commit the test file is more reasonable, do you have any better idea for this situation.

You can use testing.TempDir to create temp dir in test, and then create a file in the temp dir. For more you can refer https://pkg.go.dev/testing#B.TempDir

[xavier-hou]

@steinliber Great solution!
@jxs1211 By the way, I just try testing.TempDir, pls note that this returns an absolute path rather than creating a temp sub-dir in current dir.

[jxs1211]

@HXCGIT the TestCase in the help_test.go maybe fail, because the case needs a test file to exist in the same directory, but don't commit the test file is more reasonable, do you have any better idea for this situation.

You can use testing.TempDir to create temp dir in test, and then create a file in the temp dir. For more you can refer https://pkg.go.dev/testing#B.TempDir

good to know that!
@steinliber @HXCGIT and thank you guys

[jxs1211]

According to your advice, I update the code in the test case, but it seems to fail at the golang lint, I don't find any lint-related error after I've checked the updated code, and the test case has passed in my local environment.

[xavier-hou]

@jxs1211 Pls check the error msg, you should handle the returned error.

[IronCore864]

Thanks for the tests, and great work on the heated discussion about TempDir :)

[xavier-hou]

@jxs1211 Merged. Many thanks for the test!