You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After some code investigation, I found there are many plugins depend on the pkg/util, so I suppose it is quite important to make the package more solid, and the way to improve it is various:
better naming
better code organization
refactor to make it easier to test
ut
other aspect to make it stronger
Design
The tools in this directory have been divided into categories, like downloader\gitlab\github\k8s\helm, etc. So we could refactor it one by one, and create some sub task under this proposal,his could help us move faster and more stable.
Activity
jxs1211 commentedon Jul 11, 2022
@HXCGIT pls do me a favor to label this proposal with helpwant,refactor,enhancement,test
xavier-hou commentedon Jul 11, 2022
@jxs1211 That's right. I think the best way to start this job is to add some unit tests. Care to contribute some PR for it?
jxs1211 commentedon Jul 12, 2022
@HXCGIT Maybe we could add some sub task to do this
feat: pkg/util/helm Enhancement (sub task of pkg/util Enhancement dev…
feat: pkg/util/helm Enhancement (sub task of pkg/util Enhancement dev…
feat: pkg/util/helm Enhancement (sub task of pkg/util Enhancement dev…
feat: pkg/util/helm Enhancement (sub task of pkg/util Enhancement dev…
feat: pkg/util/helm Enhancement (sub task of pkg/util Enhancement dev…
feat: pkg/util/log Enhancement (sub task of pkg/util Enhancement devs…
Merge pull request #856 from jxs1211/feat-pkg-util-md5
Merge pull request #858 from jxs1211/feat-pkg-util-log
Merge pull request #854 from jxs1211/perf-improvement
Merge pull request #869 from jxs1211/feat-pkg-util-gitlab