Skip to content

🍀 Proposal: pkg/util Enhancement #833

Closed

Description

@jxs1211

What Would You Like to Add? Why Is This Needed?

After some code investigation, I found there are many plugins depend on the pkg/util, so I suppose it is quite important to make the package more solid, and the way to improve it is various:

  • better naming
  • better code organization
  • refactor to make it easier to test
  • ut
  • other aspect to make it stronger

Design

The tools in this directory have been divided into categories, like downloader\gitlab\github\k8s\helm, etc. So we could refactor it one by one, and create some sub task under this proposal,his could help us move faster and more stable.

Anything else

Activity

  1. jxs1211 commented on Jul 11, 2022

    @jxs1211
    Author

    @HXCGIT pls do me a favor to label this proposal with helpwant,refactor,enhancement,test

  2. xavier-hou commented on Jul 11, 2022

    @xavier-hou
    Member

    @jxs1211 That's right. I think the best way to start this job is to add some unit tests. Care to contribute some PR for it?

  3. jxs1211 commented on Jul 12, 2022

    @jxs1211
    Author

    @HXCGIT Maybe we could add some sub task to do this

  4. added a commit that references this issue on Jul 18, 2022
  5. added 3 commits that reference this issue on Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

help wantedExtra attention is neededtestut & e2e & ...

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions