Skip to content

Close #762: retire the Standing exempt list and fix round 3's leftovers - #833

Merged
derek73 merged 3 commits into
masterfrom
docs/762-close
Oct 22, 2026
Merged

derek73 merged 3 commits into
masterfrom
docs/762-close

Conversation

@derek73

@derek73 derek73 commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Closes #762. With #830, #831 and #832 merged, every decisions file except the five reference lists has a ## Standing block, so the scaffolding that held the rollout goes. This PR also fixes what round 3's reviews found.

The Standing rule, without its exempt list

  • tests/v2/decisions_without_standing.json is deleted, along with STANDING_EXEMPT_ORIGINAL (the frozen original 88) and read_standing_exempt.

  • REFERENCE_LISTS fixes the five reference lists, with its size asserted.

  • standing_roster_findings(files, reference, allowed) flags:

    • a non-reference file with no block;
    • a reference list carrying a block, or shaped like a log;
    • a listed key outside the five;
    • a misspelled heading.

    Every finding the old check could still produce is kept. The four that were only about the list (gained a block, key with no file, key not in the original set, reference list also on the list) went with it. The live test is now test_every_decisions_file_opens_with_standing_or_is_a_reference_list.

  • decisions/README.md and docs/design/AGENTS.md say so.

Round-3 leftovers

Review

Opus design-docs-reviewer, two rounds.

Mutation controls: switching off the no-block check fails 4 rows, and switching off the fixed-set check fails 1.

Tests

uv run pytest: 22,766 passed on 3.11 and on 3.15. Six fewer than before, because the exempt-list rows went. ruff and mypy are clean.

🤖 Generated with Claude Code

derek73 and others added 3 commits October 22, 2026 14:15
- decisions/P8: the #383 + #479 entry's JUAN Y GARCIA 'J. G.' reading is
  marked superseded by #461 (decisions/R3); both views give 'J. Y. G.'.
- decisions/R1: the #760 entry's nee example moved with #601 (1037c87),
  measured either side; for 'Smith, ...' the comma was a family comma
  before as after.
- decisions/M2: Not standing no longer lists the #538 resolution a later
  decision reversed; its head note carries that (README edit kind 1).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every decisions file now opens with ## Standing except the five
reference lists, so the exempt list and its frozen original set go:
tests/v2/decisions_without_standing.json is deleted and REFERENCE_LISTS,
its size asserted, fixes the one kind of file that carries no block.
standing_roster_findings and its tests follow, and decisions/README.md
and docs/design/AGENTS.md say so.

Round-3 review leftovers (#830, #831, #832):
- rules/R3: a base letter and its mark initial whole only where they
  compose; a mark NFC leaves separate (a nukta after ja, U+095B being a
  composition exclusion) is left out, as decisions/R3's #585 decided.
- decisions/parse-cost: a 2026-10-04 #601 entry records the link pin's
  re-pointing (2,301 -> 2,678); test_benchmark's _CALL_BASELINE comment
  names #624 and #625.
- decisions/cjk-full-stops: the bullet approved 2026-09-09 gets its own
  dated line, and its two Standing lines point there.
- decisions/README.md: #832's bundle-dating sentence is split into four.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…perseded; give R1's correction both policies

Review of da3e855: the split README sentence let a same-day bullet
whose text gives a date keep the bundle's date, contradicting the
cjk-full-stops line; parse-cost's #601 entry presented 2,678 as current
though #617 moved it; R1's correction gave the default policy's
before-reading only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73 derek73 added docs Documentation fixes and updates tests design labels Oct 22, 2026
@derek73 derek73 self-assigned this Oct 22, 2026
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (d6a4d9f) to head (ee6029e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          47       47           
  Lines        4659     4659           
=======================================
  Hits         4615     4615           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@derek73
derek73 merged commit 89bc611 into master Oct 22, 2026
12 checks passed
@derek73
derek73 deleted the docs/762-close branch October 22, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design docs Documentation fixes and updates tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roll the decisions Standing block out past C1

1 participant