Repository navigation
Close #762: retire the Standing exempt list and fix round 3's leftovers - #833
Merged
Merged
Conversation
- decisions/P8: the #383 + #479 entry's JUAN Y GARCIA 'J. G.' reading is marked superseded by #461 (decisions/R3); both views give 'J. Y. G.'. - decisions/R1: the #760 entry's nee example moved with #601 (1037c87), measured either side; for 'Smith, ...' the comma was a family comma before as after. - decisions/M2: Not standing no longer lists the #538 resolution a later decision reversed; its head note carries that (README edit kind 1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every decisions file now opens with ## Standing except the five reference lists, so the exempt list and its frozen original set go: tests/v2/decisions_without_standing.json is deleted and REFERENCE_LISTS, its size asserted, fixes the one kind of file that carries no block. standing_roster_findings and its tests follow, and decisions/README.md and docs/design/AGENTS.md say so. Round-3 review leftovers (#830, #831, #832): - rules/R3: a base letter and its mark initial whole only where they compose; a mark NFC leaves separate (a nukta after ja, U+095B being a composition exclusion) is left out, as decisions/R3's #585 decided. - decisions/parse-cost: a 2026-10-04 #601 entry records the link pin's re-pointing (2,301 -> 2,678); test_benchmark's _CALL_BASELINE comment names #624 and #625. - decisions/cjk-full-stops: the bullet approved 2026-09-09 gets its own dated line, and its two Standing lines point there. - decisions/README.md: #832's bundle-dating sentence is split into four. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…perseded; give R1's correction both policies Review of da3e855: the split README sentence let a same-day bullet whose text gives a date keep the bundle's date, contradicting the cjk-full-stops line; parse-cost's #601 entry presented 2,678 as current though #617 moved it; R1's correction gave the default policy's before-reading only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #833 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4659 4659
=======================================
Hits 4615 4615
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #762. With #830, #831 and #832 merged, every decisions file except the five reference lists has a
## Standingblock, so the scaffolding that held the rollout goes. This PR also fixes what round 3's reviews found.The Standing rule, without its exempt list
tests/v2/decisions_without_standing.jsonis deleted, along withSTANDING_EXEMPT_ORIGINAL(the frozen original 88) andread_standing_exempt.REFERENCE_LISTSfixes the five reference lists, with its size asserted.standing_roster_findings(files, reference, allowed)flags:Every finding the old check could still produce is kept. The four that were only about the list (gained a block, key with no file, key not in the original set, reference list also on the list) went with it. The live test is now
test_every_decisions_file_opens_with_standing_or_is_a_reference_list.decisions/README.mdanddocs/design/AGENTS.mdsay so.Round-3 leftovers
initials()drops the accent from a decomposed (NFD) name:émile zolagivese. z.#585 already decided, so it needed no issue.Jose E Maria Santosjoin likeJose e Maria Santosdoes? (the single-letter connective's Latin-capital veto was never adjudicated) #383 +JOSE E MARIA SANTOSreads the conjunctionEas an initial; an all-caps name carries no case signal to read it from #479 entry'sJUAN Y GARCIA"J. G." is marked superseded byrules.md#R3's "a conjunction never initials" is unqualified:Juan de yhas baseyand initialsJ.#461 (decisions/R3). Both views give "J. Y. G.".neeexample is corrected (kind 2). Both inputs moved with Rethink the maiden-marker rule (M2): a marker stands after the current name and takes words up to the trailing suffix run #601, measured either side of 1037c87 under both policies. ForSmith, …the comma was a family comma before as after.Not standing:no longer lists Should a suffix delimiter inside a maiden clause count as a name word beside a link?Smith, John, PhD née Puig Mr. - i Solerkeepsi Solerin the maiden name #538's resolution, which a later decision reversed. Its head note already carries that._CALL_BASELINEcomment in test_benchmark names Where doesFreiherr St John Smith MAstart: should a title that is also a particle open the name? #624 and Merge the trailing run's particle runs in group, so S2's read needs no BOUND stop or report gathering #625.Review
Opus
design-docs-reviewer, two rounds.git log -S, and the old roster's findings one by one.Mutation controls: switching off the no-block check fails 4 rows, and switching off the fixed-set check fails 1.
Tests
uv run pytest: 22,766 passed on 3.11 and on 3.15. Six fewer than before, because the exempt-list rows went. ruff and mypy are clean.🤖 Generated with Claude Code