Skip to content

Give decisions/R1, R2, R3, R5, render-default and comparison-surface a Standing block (#762) - #830

Merged
derek73 merged 5 commits into
masterfrom
docs/standing-r-section
Oct 22, 2026
Merged

derek73 merged 5 commits into
masterfrom
docs/standing-r-section

Conversation

@derek73

@derek73 derek73 commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Part of #762, final round. This batch covers the R section plus the two rendering files.

What changed

Six files in docs/design/decisions/ gain a ## Standing block and a ## Log heading, and their keys leave tests/v2/decisions_without_standing.json:

  • R1 (fields are views of the parsed words)
  • R2 (the all-particles family_base divergence)
  • R3 (initials honor the fold)
  • R5 (the case-repair gate)
  • render-default
  • comparison-surface

Each Standing line states what the tree does today. Every example a line cites was parsed on this branch: for view lines, initials(), capitalized() and capitalized(force=True) were checked; for lines about them, replace() and revise() too. The facade examples were run through HumanName.

Edit-kind-1 head notes

Added where a later decision reversed an entry in whole or in part:

Edit-kind-2 correction

R3's #585 entry cites the Devanagari example ज़ाकिर. The text had stored it decomposed (U+091C U+093C), which initials ज., so it read as the very bug #585's review fixed. The example is now written with the U+095B escape, and a note says what was wrong.

Review

design-docs-reviewer (opus) ran four rounds. Rounds 1–3 found 8, 8 and 2 problems; round 4 found nothing.

The MD - PhD - FACS rows are pinned under the " - " delimiter (_SD in tests/v2/cases.py), and the R1 note now says which reading moved under which policy.

Stale text found and left

Tests

  • test_design_docs, test_doc_citations and test_rules_doc pass.
  • The full suite on 3.11: 22,772 passed, 125 skipped, 3 xfailed.
  • The full suite on 3.15: 22,770 passed, and two clock-timed benchmark rows failed (unmatched_opens, maiden_pairs). Rerun alone, both pass twice on this branch and twice on an origin/master worktree. The branch changes no code.

Generated by Claude Code

…a Standing block (#762)

Each file gains a ## Standing block (one present-tense line per decision
in force, pointing at its entry) and a ## Log heading, and leaves
decisions_without_standing.json. Entries reversed in whole or in part
gain an edit-kind-1 head note: R1's #429 (between-piece rule, #436/#437),
R2's 2026-08-16 #385 (#404/#385), its pre-merge coherence pass and
2026-08-29 #461, R3's #462 (#528), and R5's #407-arc extraction (#492)
and two 2026-08-29 entries (#383/#479).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018LRitdX44LU6ZNvxM7v8QX
Scope R2's unjoined-mark line to initials() and point at R4's carve-out;
state R5's gate over the words outside the suffix and name its main
fence's boundary; spell R3's composition examples with escapes and
correct #585's Devanagari example in place (edit kind 2); mark the
heads of R3's #528, R1's #436/#437 and R2's 2026-08-16 bullet against
what reversed them; re-point two Elsewhere attributions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018LRitdX44LU6ZNvxM7v8QX
…delimiter (#762)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018LRitdX44LU6ZNvxM7v8QX
Key-form pointer in R5; R1's #436/#437 head note names both corpus names
#602 moved and the policies, says no entry records the nee move, and
spells the (Derek) heads; the #613 note moves from #429's body to its
head; R2 names its lexicon; R3's edit-kind-2 note no longer calls the
decomposed nukta initial correct, and its Elsewhere line drops an
own-file pointer; R4's CONJUNCTION CARVE-OUT head marked against #461.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018LRitdX44LU6ZNvxM7v8QX
R1's #436/#437 head note names M2's #601 as the entry that moved
Smith, MD nee Jones PhD; the differential-ledger pointers in R2 and R3
carry the twin key that picks the snapshot entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018LRitdX44LU6ZNvxM7v8QX
@derek73 derek73 added docs Documentation fixes and updates tests design labels Oct 22, 2026 — with Claude
@derek73 derek73 self-assigned this Oct 22, 2026
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (9be7261) to head (cc2b0ef).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #830   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          47       47           
  Lines        4659     4659           
=======================================
  Hits         4615     4615           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@derek73
derek73 merged commit ba6adf7 into master Oct 22, 2026
12 checks passed
@derek73
derek73 deleted the docs/standing-r-section branch October 22, 2026 21:03
derek73 added a commit that referenced this pull request Oct 22, 2026
…rs (#833)

* Mark P8's and R1's moved readings; give M2's #549 its head note's place

- decisions/P8: the #383 + #479 entry's JUAN Y GARCIA 'J. G.' reading is
  marked superseded by #461 (decisions/R3); both views give 'J. Y. G.'.
- decisions/R1: the #760 entry's nee example moved with #601 (1037c87),
  measured either side; for 'Smith, ...' the comma was a family comma
  before as after.
- decisions/M2: Not standing no longer lists the #538 resolution a later
  decision reversed; its head note carries that (README edit kind 1).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Close #762: retire the Standing exempt list; fix the round-3 leftovers

Every decisions file now opens with ## Standing except the five
reference lists, so the exempt list and its frozen original set go:
tests/v2/decisions_without_standing.json is deleted and REFERENCE_LISTS,
its size asserted, fixes the one kind of file that carries no block.
standing_roster_findings and its tests follow, and decisions/README.md
and docs/design/AGENTS.md say so.

Round-3 review leftovers (#830, #831, #832):
- rules/R3: a base letter and its mark initial whole only where they
  compose; a mark NFC leaves separate (a nukta after ja, U+095B being a
  composition exclusion) is left out, as decisions/R3's #585 decided.
- decisions/parse-cost: a 2026-10-04 #601 entry records the link pin's
  re-pointing (2,301 -> 2,678); test_benchmark's _CALL_BASELINE comment
  names #624 and #625.
- decisions/cjk-full-stops: the bullet approved 2026-09-09 gets its own
  dated line, and its two Standing lines point there.
- decisions/README.md: #832's bundle-dating sentence is split into four.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Scope the same-day dating rule to undated bullets; mark #601's pin superseded; give R1's correction both policies

Review of da3e855: the split README sentence let a same-day bullet
whose text gives a date keep the bundle's date, contradicting the
cjk-full-stops line; parse-cost's #601 entry presented 2,678 as current
though #617 moved it; R1's correction gave the default policy's
before-reading only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design docs Documentation fixes and updates tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants