Repository navigation
fix(install): upgrade from the home folder no longer rewrites agents' user-wide setup - #3333
Merged
Merged
Conversation
… user-wide setup
`codegraph upgrade` runs `codegraph install --refresh`, which sweeps the
global and the local location from whatever folder the terminal is in, and
a new terminal opens in the home folder. There an agent's project file and
its user-wide file are the same file: `./.cursor/mcp.json` is
`~/.cursor/mcp.json`, `./.codex/config.toml` is `~/.codex/config.toml`, and
likewise for Gemini CLI and Qwen Code. The local half of the sweep detected
each global install as a local one and re-installed it as a project's:
- Cursor's global entry had `--path ${workspaceFolder}` replaced with the
home folder's absolute path, so every Cursor workspace was served the
home folder (until a later refresh from some other folder put it back);
- Codex, Gemini CLI and Qwen Code got `~/AGENTS.md`, `~/GEMINI.md` and
`~/QWEN.md`, which none of them reads as its user-wide instructions.
refreshTargets now finds nothing configured for a local sweep from a folder
that holds no project, the folders `init` already refuses (the home
folder, a folder above it, a filesystem root), using the same
unsafeIndexRootReason check. The global half is unchanged, and a local
sweep inside a project refreshes as before. Nothing is printed for the
skipped half, so an upgrade from the home folder stays as quiet as one
that has nothing local to refresh.
Validation:
- installer-targets.test.ts: a new test installs every agent globally into
a temp home, runs the local sweep from it, and checks every file there
is byte-identical, no AGENTS.md / GEMINI.md / QWEN.md appears, and
Cursor keeps `${workspaceFolder}`. Red on main (Cursor reported
refreshed), green here. A second test checks a local sweep inside a
project still refreshes a stale block. The whole file passes
(616 passed, 10 skipped), as do installer, installer-links-simulated,
upgrade and cli-install-init (101 passed).
- Real CLI against a temp HOME (every agent installed globally, then
`install --refresh` from HOME): v1.6.3 sources changed `.cursor/mcp.json`
and created AGENTS.md, GEMINI.md and QWEN.md; this branch left all 31
files byte-identical. From a project with a local Codex install, both
refresh its AGENTS.md.
Left out: an explicit `codegraph install --location local` run from the home
folder still writes there; that's a direct request, not a sweep, and
refusing it is a separate call.
PR #3281 (@b84330808) and PR #3288 (@LuisAlbertoMK) proposed the same guard;
this follows #3281's quiet shape.
Fixes #3234
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
colbymchenry
force-pushed
the
claude/issue-3234-refresh-skips-home
branch
from
November 18, 2026 03:54
c0a9604 to
5b110ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codegraph upgrade(which runscodegraph install --refresh) from the home folder rewrote each agent's user-wide setup as if it were a project's. Most visibly, Cursor's global CodeGraph server was pinned to the home folder for every workspace, and~/AGENTS.md,~/GEMINI.mdand~/QWEN.mdappeared. A local refresh from a folder that holds no project now finds nothing to refresh there.Root cause
install --refreshsweeps both locations from the current folder, and a new terminal opens in the home folder. There an agent's project file and its user-wide file are the same file (./.cursor/mcp.jsonis~/.cursor/mcp.json,./.codex/config.tomlis~/.codex/config.toml, and likewise for Gemini CLI and Qwen Code).refreshTargets(…, 'local')detected each global install as a local one and re-installed it as a project's:--path ${workspaceFolder}became--path <home folder>in~/.cursor/mcp.json, so every workspace was served the home folder (a later refresh from another folder flips it back);~/AGENTS.md,~/GEMINI.md,~/QWEN.md, files none of them reads as user-wide instructions.Fix
refreshTargetsreports every targetnot-configuredfor alocalsweep from a folder that holds no project: the folderscodegraph initalready refuses (home, a folder above it, a filesystem root), through the sameunsafeIndexRootReason. The global half of the sweep is unchanged, a local sweep inside a project refreshes as before, and nothing extra is printed.Validation
__tests__/installer-targets.test.ts: a new test installs every agent globally in a temp home, runs the local sweep from it, and checks every file there is byte-identical, noAGENTS.md/GEMINI.md/QWEN.mdappears, and Cursor keeps${workspaceFolder}. Red on main (cursor: expected [ 'not-configured', 'unsupported' ] to include 'refreshed'), green here. A second test checks that a local sweep inside a project still refreshes a stale block. Whole file: 616 passed, 10 skipped.installer,installer-links-simulated,upgrade,cli-install-init: 101 passed.Real CLI, temp HOME (every agent installed globally, then
install --refreshfrom HOME):.cursor/mcp.jsonchanged;AGENTS.md,GEMINI.md,QWEN.mdcreatedAGENTS.mdrefreshedAGENTS.mdrefreshedFull suite: see the PR's READY note.
Left out
An explicit
codegraph install --location localrun from the home folder still writes there. That's a direct request rather than a sweep, so whether to refuse it is a separate call.Credit
Thanks @shoma-endo for the report. PR #3281 (@b84330808) and PR #3288 (@LuisAlbertoMK) proposed the same guard; this follows #3281's quiet shape (no new status, no message on every upgrade).
Fixes #3234
🤖 Generated with Claude Code