Skip to content

fix(install): upgrade from the home folder no longer rewrites agents' user-wide setup - #3333

Merged
colbymchenry merged 1 commit into
mainfrom
claude/issue-3234-refresh-skips-home
Nov 18, 2026
Merged

colbymchenry merged 1 commit into
mainfrom
claude/issue-3234-refresh-skips-home

Conversation

@colbymchenry

Copy link
Copy Markdown
Owner

Summary

codegraph upgrade (which runs codegraph install --refresh) from the home folder rewrote each agent's user-wide setup as if it were a project's. Most visibly, Cursor's global CodeGraph server was pinned to the home folder for every workspace, and ~/AGENTS.md, ~/GEMINI.md and ~/QWEN.md appeared. A local refresh from a folder that holds no project now finds nothing to refresh there.

Root cause

install --refresh sweeps both locations from the current folder, and a new terminal opens in the home folder. There an agent's project file and its user-wide file are the same file (./.cursor/mcp.json is ~/.cursor/mcp.json, ./.codex/config.toml is ~/.codex/config.toml, and likewise for Gemini CLI and Qwen Code). refreshTargets(…, 'local') detected each global install as a local one and re-installed it as a project's:

  • Cursor: --path ${workspaceFolder} became --path <home folder> in ~/.cursor/mcp.json, so every workspace was served the home folder (a later refresh from another folder flips it back);
  • Codex, Gemini CLI, Qwen Code: the instructions block went into ~/AGENTS.md, ~/GEMINI.md, ~/QWEN.md, files none of them reads as user-wide instructions.

Fix

refreshTargets reports every target not-configured for a local sweep from a folder that holds no project: the folders codegraph init already refuses (home, a folder above it, a filesystem root), through the same unsafeIndexRootReason. The global half of the sweep is unchanged, a local sweep inside a project refreshes as before, and nothing extra is printed.

Validation

  • __tests__/installer-targets.test.ts: a new test installs every agent globally in a temp home, runs the local sweep from it, and checks every file there is byte-identical, no AGENTS.md / GEMINI.md / QWEN.md appears, and Cursor keeps ${workspaceFolder}. Red on main (cursor: expected [ 'not-configured', 'unsupported' ] to include 'refreshed'), green here. A second test checks that a local sweep inside a project still refreshes a stale block. Whole file: 616 passed, 10 skipped. installer, installer-links-simulated, upgrade, cli-install-init: 101 passed.

  • Real CLI, temp HOME (every agent installed globally, then install --refresh from HOME):

    v1.6.3 sources this branch
    files changed or created in HOME .cursor/mcp.json changed; AGENTS.md, GEMINI.md, QWEN.md created none (31 files byte-identical)
    output 4 "refreshed" lines "All configured agent surfaces are already current."
    refresh from a project with a local Codex install its AGENTS.md refreshed its AGENTS.md refreshed
  • Full suite: see the PR's READY note.

Left out

An explicit codegraph install --location local run from the home folder still writes there. That's a direct request rather than a sweep, so whether to refuse it is a separate call.

Credit

Thanks @shoma-endo for the report. PR #3281 (@b84330808) and PR #3288 (@LuisAlbertoMK) proposed the same guard; this follows #3281's quiet shape (no new status, no message on every upgrade).

Fixes #3234

🤖 Generated with Claude Code

… user-wide setup

`codegraph upgrade` runs `codegraph install --refresh`, which sweeps the
global and the local location from whatever folder the terminal is in, and
a new terminal opens in the home folder. There an agent's project file and
its user-wide file are the same file: `./.cursor/mcp.json` is
`~/.cursor/mcp.json`, `./.codex/config.toml` is `~/.codex/config.toml`, and
likewise for Gemini CLI and Qwen Code. The local half of the sweep detected
each global install as a local one and re-installed it as a project's:

- Cursor's global entry had `--path ${workspaceFolder}` replaced with the
  home folder's absolute path, so every Cursor workspace was served the
  home folder (until a later refresh from some other folder put it back);
- Codex, Gemini CLI and Qwen Code got `~/AGENTS.md`, `~/GEMINI.md` and
  `~/QWEN.md`, which none of them reads as its user-wide instructions.

refreshTargets now finds nothing configured for a local sweep from a folder
that holds no project, the folders `init` already refuses (the home
folder, a folder above it, a filesystem root), using the same
unsafeIndexRootReason check. The global half is unchanged, and a local
sweep inside a project refreshes as before. Nothing is printed for the
skipped half, so an upgrade from the home folder stays as quiet as one
that has nothing local to refresh.

Validation:
- installer-targets.test.ts: a new test installs every agent globally into
  a temp home, runs the local sweep from it, and checks every file there
  is byte-identical, no AGENTS.md / GEMINI.md / QWEN.md appears, and
  Cursor keeps `${workspaceFolder}`. Red on main (Cursor reported
  refreshed), green here. A second test checks a local sweep inside a
  project still refreshes a stale block. The whole file passes
  (616 passed, 10 skipped), as do installer, installer-links-simulated,
  upgrade and cli-install-init (101 passed).
- Real CLI against a temp HOME (every agent installed globally, then
  `install --refresh` from HOME): v1.6.3 sources changed `.cursor/mcp.json`
  and created AGENTS.md, GEMINI.md and QWEN.md; this branch left all 31
  files byte-identical. From a project with a local Codex install, both
  refresh its AGENTS.md.

Left out: an explicit `codegraph install --location local` run from the home
folder still writes there; that's a direct request, not a sweep, and
refusing it is a separate call.

PR #3281 (@b84330808) and PR #3288 (@LuisAlbertoMK) proposed the same guard;
this follows #3281's quiet shape.

Fixes #3234

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@colbymchenry
colbymchenry force-pushed the claude/issue-3234-refresh-skips-home branch from c0a9604 to 5b110ab Compare November 18, 2026 03:54
@colbymchenry
colbymchenry merged commit e10d392 into main Nov 18, 2026
@colbymchenry
colbymchenry deleted the claude/issue-3234-refresh-skips-home branch November 18, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install --refresh (via upgrade) writes the CodeGraph block into $HOME/AGENTS.md when cwd is $HOME

1 participant