Skip to content

fix(install): a local refresh refuses the home directory (#3234) - #3288

Open
LuisAlbertoMK wants to merge 1 commit into
colbymchenry:mainfrom
LuisAlbertoMK:fix/refresh-home-guard
Open

LuisAlbertoMK wants to merge 1 commit into
colbymchenry:mainfrom
LuisAlbertoMK:fix/refresh-home-guard

Conversation

@LuisAlbertoMK

Copy link
Copy Markdown

A project-local install resolves every path from the working directory. Run from your home directory (or a filesystem root), codegraph install --refresh — which codegraph upgrade runs by default — wrote the CodeGraph instructions block into $HOME/AGENTS.md, the user's own global instructions file, not a project's. <cwd>/.codex resolving to ~/.codex made Codex's local layer look already configured, so the sweep rewrote it.

refreshTargets now refuses a local sweep from a directory that unsafeIndexRootReason already rejects for init (home directory, a parent of it, or a filesystem root). Every target reports a new skipped status with the reason, and the CLI says why and points at running it from a project directory. Global refresh is unchanged.

Added two tests in installer-targets.test.ts: one that seeds a global Codex install and refreshes from $HOME, asserting every report is skipped and no $HOME/AGENTS.md appears; and one that a real project-local refresh still works.

Tested: tsc --noEmit clean, npm run build, focused tests (new ones + cli-install-init + status-json), and the full installer-targets file (576 passed, 50 skipped).

colbymchenry added a commit that referenced this pull request Nov 18, 2026
… user-wide setup

`codegraph upgrade` runs `codegraph install --refresh`, which sweeps the
global and the local location from whatever folder the terminal is in, and
a new terminal opens in the home folder. There an agent's project file and
its user-wide file are the same file: `./.cursor/mcp.json` is
`~/.cursor/mcp.json`, `./.codex/config.toml` is `~/.codex/config.toml`, and
likewise for Gemini CLI and Qwen Code. The local half of the sweep detected
each global install as a local one and re-installed it as a project's:

- Cursor's global entry had `--path ${workspaceFolder}` replaced with the
  home folder's absolute path, so every Cursor workspace was served the
  home folder (until a later refresh from some other folder put it back);
- Codex, Gemini CLI and Qwen Code got `~/AGENTS.md`, `~/GEMINI.md` and
  `~/QWEN.md`, which none of them reads as its user-wide instructions.

refreshTargets now finds nothing configured for a local sweep from a folder
that holds no project, the folders `init` already refuses (the home
folder, a folder above it, a filesystem root), using the same
unsafeIndexRootReason check. The global half is unchanged, and a local
sweep inside a project refreshes as before. Nothing is printed for the
skipped half, so an upgrade from the home folder stays as quiet as one
that has nothing local to refresh.

Validation:
- installer-targets.test.ts: a new test installs every agent globally into
  a temp home, runs the local sweep from it, and checks every file there
  is byte-identical, no AGENTS.md / GEMINI.md / QWEN.md appears, and
  Cursor keeps `${workspaceFolder}`. Red on main (Cursor reported
  refreshed), green here. A second test checks a local sweep inside a
  project still refreshes a stale block. The whole file passes
  (616 passed, 10 skipped), as do installer, installer-links-simulated,
  upgrade and cli-install-init (101 passed).
- Real CLI against a temp HOME (every agent installed globally, then
  `install --refresh` from HOME): v1.6.3 sources changed `.cursor/mcp.json`
  and created AGENTS.md, GEMINI.md and QWEN.md; this branch left all 31
  files byte-identical. From a project with a local Codex install, both
  refresh its AGENTS.md.

Left out: an explicit `codegraph install --location local` run from the home
folder still writes there; that's a direct request, not a sweep, and
refusing it is a separate call.

PR #3281 (@b84330808) and PR #3288 (@LuisAlbertoMK) proposed the same guard;
this follows #3281's quiet shape.

Fixes #3234

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
colbymchenry added a commit that referenced this pull request Nov 18, 2026
… user-wide setup (#3333)

`codegraph upgrade` runs `codegraph install --refresh`, which sweeps the
global and the local location from whatever folder the terminal is in, and
a new terminal opens in the home folder. There an agent's project file and
its user-wide file are the same file: `./.cursor/mcp.json` is
`~/.cursor/mcp.json`, `./.codex/config.toml` is `~/.codex/config.toml`, and
likewise for Gemini CLI and Qwen Code. The local half of the sweep detected
each global install as a local one and re-installed it as a project's:

- Cursor's global entry had `--path ${workspaceFolder}` replaced with the
  home folder's absolute path, so every Cursor workspace was served the
  home folder (until a later refresh from some other folder put it back);
- Codex, Gemini CLI and Qwen Code got `~/AGENTS.md`, `~/GEMINI.md` and
  `~/QWEN.md`, which none of them reads as its user-wide instructions.

refreshTargets now finds nothing configured for a local sweep from a folder
that holds no project, the folders `init` already refuses (the home
folder, a folder above it, a filesystem root), using the same
unsafeIndexRootReason check. The global half is unchanged, and a local
sweep inside a project refreshes as before. Nothing is printed for the
skipped half, so an upgrade from the home folder stays as quiet as one
that has nothing local to refresh.

Validation:
- installer-targets.test.ts: a new test installs every agent globally into
  a temp home, runs the local sweep from it, and checks every file there
  is byte-identical, no AGENTS.md / GEMINI.md / QWEN.md appears, and
  Cursor keeps `${workspaceFolder}`. Red on main (Cursor reported
  refreshed), green here. A second test checks a local sweep inside a
  project still refreshes a stale block. The whole file passes
  (616 passed, 10 skipped), as do installer, installer-links-simulated,
  upgrade and cli-install-init (101 passed).
- Real CLI against a temp HOME (every agent installed globally, then
  `install --refresh` from HOME): v1.6.3 sources changed `.cursor/mcp.json`
  and created AGENTS.md, GEMINI.md and QWEN.md; this branch left all 31
  files byte-identical. From a project with a local Codex install, both
  refresh its AGENTS.md.

Left out: an explicit `codegraph install --location local` run from the home
folder still writes there; that's a direct request, not a sweep, and
refusing it is a separate call.

PR #3281 (@b84330808) and PR #3288 (@LuisAlbertoMK) proposed the same guard;
this follows #3281's quiet shape.

Fixes #3234

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant