Skip to content
This repository was archived by the owner on Jan 17, 2021. It is now read-only.

Adding git bash support, closes #94 - #124

Closed
eargollo wants to merge 3 commits into
coder:masterfrom
eargollo:windows-gitbash
Closed

eargollo wants to merge 3 commits into
coder:masterfrom
eargollo:windows-gitbash

Conversation

@eargollo

@eargollo eargollo commented Jul 8, 2019

Copy link
Copy Markdown
Contributor
  • Adding support to Windows when using git bash
  • It is able to understand relative paths on Windows and translate to the Linux server
  • In order to work, user will need to download rsych for Windows and put on path

@deansheather deansheather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an error saying that it couldn't enable connection reuse feature because it couldn't stat the ~/.ssh directory. Could you please fix this?

Also, I struggled to install rsync in Git for Windows, could you please provide a short guide or a link to a guide on how to install rsync in the README?

Comment thread README.md Outdated
Comment thread main.go Outdated
Comment thread main.go Outdated
Comment thread main.go Outdated
Comment thread sshcode.go Outdated
Comment thread main.go
@eargollo

Copy link
Copy Markdown
Contributor Author

@deansheather, I fixed all the issues but the enable connection error you mentioned. I could not reproduce it. Can you give me some more info on it?

@Merith-TK

Copy link
Copy Markdown
Contributor

My build is finnished for now. I am waiting for @eargollo to do his thing.

@Merith-TK

Copy link
Copy Markdown
Contributor

@eargollo Can you email me with the email on my profile?

@eargollo

Copy link
Copy Markdown
Contributor Author

@Merith-TK, sorry for the long delay. I was on vacations.

What is the status? How can I be of help?

@Merith-TK

Merith-TK commented Aug 15, 2019 via email

Copy link
Copy Markdown
Contributor

@deansheather

Copy link
Copy Markdown
Collaborator

Should this PR be closed in favor of the other one? @Merith-TK @eargollo

@Merith-TK

Copy link
Copy Markdown
Contributor

I think so, but according to my last communication with @eargollo , he is mostlikely swamped by work.

Currently my fork is working with oen caviat the i cant explain... I sent it to you over discord @deansheather

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants