You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 17, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 17, 2021. It is now read-only.
Will there any potential future support for mingw-w64 go/windows native (not wsl)?
I'm not exactly sure how sshcode and go work so I'm sorry if this is a dumb question
Right now we only support remote linux environments, I imagine we'd probably support starting sshcode remotely in a docker container before we support native windows since that's more platform-agnostic
I have made a PR with some rather basic mingw/msys support.
only as the user though, not the server #127
What this does is allow sshcode to run inside a msys client, for example $ sshcode.exe --skipsync merith@192.168.0.101 will open a sshcode session as if you were running on linux
Well, saying our changes make it so the lines wont like up just right, i think we would have to find the diff between our branches and manually add them.
I don't recall taking code out but rather adding some lines for the conversion of slashes. I haven't had the time to merge my code into your branch and test it myself.
mayeb yours is slightly out of date? and when i run the merged code, it
still works, it turns out i dont know how to use the filepath to open
`/home/$USERNAME/workspace`
—Merith
On Wed, Jul 31, 2019 at 9:05 AM Eduardo Argollo ***@***.***> wrote:
I don't recall taking code out but rather adding some lines for the
conversion of slashes. I haven't had the time to merge my code into your
branch and test it myself.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#94>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACPQOXWBQEVCJZRKT2O2UZLQCGZ53ANCNFSM4HLEWMUQ>
.
Activity
sreya commentedon May 7, 2019
Right now we only support remote linux environments, I imagine we'd probably support starting
sshcoderemotely in a docker container before we support native windows since that's more platform-agnostic1480c1 commentedon May 7, 2019
If it's docker then that's fine
eargollo commentedon Jun 18, 2019
The PR #118 has code that supports Windows with MINGW.
I will be re-submitting this code as soon as #121 gets merged.
Merith-TK commentedon Jul 24, 2019
I have made a PR with some rather basic mingw/msys support.
only as the user though, not the server
#127
What this does is allow
sshcodeto run inside amsysclient, for example$ sshcode.exe --skipsync merith@192.168.0.101will open a sshcode session as if you were running on linuxeargollo commentedon Jul 25, 2019
The code in #124 should work. I haven't had the time to address the comments in order to get it merged yet.
Merith-TK commentedon Jul 29, 2019
@eargollo Wanna combine your changes to mine? https://github.com/Merith-TK/sshcode {branch
msys-support}Your changes are for the windows filepath conversion, mine are for getting chrome support. (from what i see atleast)
eargollo commentedon Jul 29, 2019
Sure thing. Let's do it. Do you want me to merge your changes there? How do you want to do it?
Merith-TK commentedon Jul 30, 2019
Well, saying our changes make it so the lines wont like up just right, i think we would have to find the
diffbetween our branches and manually add them.Merith-TK commentedon Jul 30, 2019
I have added you as a Collaborator to my repo
Merith-TK commentedon Jul 31, 2019
@eargollo I have applied my code into yours (offline at the moment) and it does execute properly
What i dont fully understand is why your
sshcode.gohas only (with my code added in) 432 lines of code, and mine has 573?eargollo commentedon Jul 31, 2019
I don't recall taking code out but rather adding some lines for the conversion of slashes. I haven't had the time to merge my code into your branch and test it myself.
Merith-TK commentedon Jul 31, 2019
deansheather commentedon Aug 2, 2019
Please discuss PR specific stuff in one of the relevant PRs.
Merith-TK commentedon Aug 2, 2019
quesiton is, which PR do we discuss on?
Mine #127 or his #124 ?