Skip to content

Update VS Code 1.95 - #7059

Merged
code-asher merged 6 commits into
mainfrom
asher/update-vscode-1.95
Nov 1, 2024
Merged

code-asher merged 6 commits into
mainfrom
asher/update-vscode-1.95

Conversation

@code-asher

@code-asher code-asher commented Oct 31, 2024 •

Copy link
Copy Markdown
Member

Closes #7052
Fixes #7056.

@code-asher
code-asher requested a review from a team as a code owner October 31, 2024 19:56
@code-asher
code-asher force-pushed the asher/update-vscode-1.95 branch 2 times, most recently from 6146abe to 52b1aaa Compare October 31, 2024 22:25
@code-asher
code-asher force-pushed the asher/update-vscode-1.95 branch from 52b1aaa to f248926 Compare October 31, 2024 23:25
With the switch to esm, this require is now failing.  fs is already
imported, so we can just use it anyway.

Fixes #7056.
@code-asher code-asher linked an issue Nov 1, 2024 that may be closed by this pull request
2 tasks done
@code-asher
code-asher merged commit f835dea into main Nov 1, 2024
@code-asher
code-asher deleted the asher/update-vscode-1.95 branch November 1, 2024 20:32
@bcpeinhardt

Copy link
Copy Markdown

It got merged while I was reviewing 💀 My only comment was gonna be "so many hashes" haha.

code-asher added a commit that referenced this pull request Nov 1, 2024
* Update Code to 1.95.1
* Update Node to 20.18.0
* Update build.yaml to use Ubuntu 22.04
  This is to resolve a gcc error.  Might have to address
  the release step later as well.
* Fix --stdin-to-clipboard
  With the switch to esm, the fs require is failing.  fs is already
  imported, so we can just use it anyway.
* Fix mangled exports
* Update CSP hashes
@bcpeinhardt

Copy link
Copy Markdown

Also funny that minification respects the export alias.

@code-asher

code-asher commented Nov 1, 2024 •

Copy link
Copy Markdown
Member Author

My bad did not realize you were reviewing!! I will need to get used to not just wild-west merging here lol

Also funny that minification respects the export alias.

Haha yeah, honestly a relief because otherwise we would have to do some crazy things like import it as $6F or whatever name it choose, or dig into the build process and see if we can change the behavior.

@benz0li

benz0li commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

Ping @code-asher: code-server-4.95.1-rc.1-linux-amd64.tar.gz with Code 1.95.1 is deployed at https://coder.jupyter.b-data.ch.

@benz0li

benz0li commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

Ping @code-asher: code-server-4.95.1-rc.2-linux-amd64.tar.gz with Code 1.95.1 is deployed at https://coder.jupyter.b-data.ch.

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • web view

Workspaces and Jupyter Notebooks also work fine:

  • ms-toolsai.jupyter@2024.10.0
  • ms-python.python@2024.18.0

@benz0li

benz0li commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

code-server v4.95.1-rc.2 also resolves issue #7042.

@benz0li

benz0li commented Nov 10, 2024 •

Copy link
Copy Markdown
Contributor

Unofficial and untested Linux/RISC-V 64-bit (linux/riscv64) and Linux/Power 64-bit (linux/ppc64le) release assets are available at https://gitlab.b-data.ch/coder/code-server/-/releases/v4.95.1.

yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
* Update Code to 1.95.1
* Update Node to 20.18.0
* Update build.yaml to use Ubuntu 22.04
  This is to resolve a gcc error.  Might have to address
  the release step later as well.
* Fix --stdin-to-clipboard
  With the switch to esm, the fs require is failing.  fs is already
  imported, so we can just use it anyway.
* Fix mangled exports
* Update CSP hashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic require error with --stdin-to-clipboard in v4.94.2-rc.1 Update Code to 1.95

3 participants