Skip to content

Update Code to 1.95 #7052

Closed
Closed

Description

@benz0li

What is your suggestion?

Update Code to 1.95

Why do you want this feature?

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

Activity

  1. benz0li commented on Oct 26, 2024

    @benz0li
    ContributorAuthor

    Expected release date: 10/29 (this may change)

    – microsoft/vscode#231789

  2. benz0li commented on Oct 26, 2024

    @benz0li
    ContributorAuthor

    Note to self: Check Node.js version in lib/vscode/remote/.npmrc. Update .node-version and package.json accordingly.

  3. Kidsunbo commented on Oct 26, 2024

    @Kidsunbo

    Still wait for v4.94.2 to be released..

  4. benz0li commented on Oct 29, 2024

    @benz0li
    ContributorAuthor

    Code - OSS v1.95.0 was released today: https://github.com/microsoft/vscode/releases/tag/1.95.0

  5. benz0li commented on Oct 29, 2024

    @benz0li
    ContributorAuthor

    @code-asher I will try to create a pull request early next morning (CET).

  6. benz0li commented on Oct 30, 2024

    @benz0li
    ContributorAuthor

    @code-asher You mixed pre and post build patches:

    quilt push -f
    ...
    can't find file to patch at input line 279
    Perhaps you used the wrong -p or --strip option?
    The text leading up to this was:
    --------------------------
    |Index: code-server/lib/vscode/src/server-main.js
    |===================================================================
    |--- code-server.orig/lib/vscode/src/server-main.js
    |+++ code-server/lib/vscode/src/server-main.js
    --------------------------
    No file to patch.  Skipping patch.
    1 out of 1 hunk ignored
    Applied patch patches/integration.diff (forced; needs refresh)
    

    ℹ This means that I am unable to do the preparatory work for this release.

  7. code-asher commented on Oct 30, 2024

    @code-asher
    Member

    Hmm I am not sure that is quite right, they used to write and commit server-main.js directly so it was never post-build before, just a regular source file like anything else. It looks like they renamed server-main.js to server-main.ts (and added types), so we will have to update to patch the renamed file now.

  8. benz0li commented on Oct 31, 2024

    @benz0li
    ContributorAuthor

    This was a hasty conclusion of mine, then.

    @code-asher Can you tackle this?

  9. code-asher commented on Oct 31, 2024

    @code-asher
    Member

    Yup, no problem!

  10. benz0li commented on Nov 1, 2024

    @benz0li
    ContributorAuthor
  11. code-asher commented on Nov 1, 2024

    @code-asher
    Member

    Ah thanks for the heads up.

  12. code-asher commented on Nov 4, 2024

    @code-asher
    Member

    Just released the RC earlier today. We are holding off on promoting it to a full release until we figure out #7042 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSome improvement that isn't a feature

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions