Skip to content

Fix vscode-textmate dependency - #299

Closed
foresthoffman wants to merge 5 commits into
masterfrom
fix/vscode-textmate
Closed

foresthoffman wants to merge 5 commits into
masterfrom
fix/vscode-textmate

Conversation

@foresthoffman

Copy link
Copy Markdown
Contributor

Describe in detail the problem you had and how this PR fixes it

There was a 'vscode-textmate' dependency for the CoenraadS.bracket-pair-colorizer-2 extension, which included 'oniguruma' as a dependency. This PR adds a section to the bootstrapFork module requirement which will allow the inclusion of dependencies that should exist with the unpacked version of VS Code.

Is there an open issue you can link to?

#200 (comment)

@polymerchm

Copy link
Copy Markdown

Fixed!!! I de-installed the extension Debugger for Chrome from VSCode and it now works. Must have been a conflict for redundant modules.

@kylecarbs

Copy link
Copy Markdown
Member

I don't think this is a problem anymore. Would be good to check. cc: @foresthoffman

@foresthoffman

foresthoffman commented Apr 17, 2019 •

Copy link
Copy Markdown
Contributor Author

@kylecarbs I believe it is no longer an issue. Going to close this out.

@code-asher
code-asher deleted the fix/vscode-textmate branch January 16, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants