Skip to content

Fix vscode-textmate dependency - #284

Closed
foresthoffman wants to merge 4 commits into
coder:masterfrom
foresthoffman:fix/vscode-textmate
Closed

foresthoffman wants to merge 4 commits into
coder:masterfrom
foresthoffman:fix/vscode-textmate

Conversation

@foresthoffman

Copy link
Copy Markdown
Contributor

Describe in detail the problem you had and how this PR fixes it

There was a 'vscode-textmate' dependency for the CoenraadS.bracket-pair-colorizer-2 extension, which included 'oniguruma' as a dependency. This PR adds a section to the bootstrapFork module requirement which will allow the inclusion of dependencies that should exist with the unpacked version of VS Code.

Is there an open issue you can link to?

#200 (comment)

@foresthoffman foresthoffman self-assigned this Mar 18, 2019
@foresthoffman

Copy link
Copy Markdown
Contributor Author

Closing in favor of #299. Making the PR from branch rather than a fork.

@foresthoffman
foresthoffman deleted the fix/vscode-textmate branch March 22, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant