Skip to content

Extract display language patch and submit PR upstream #4703

Closed as not planned
Closed as not planned
Extract display language patch and submit PR upstream#4703
Assignees
jsjoeio
Labels
featureNew user visible feature
Milestone
4.5.0

Description

@jsjoeio
jsjoeio
opened on Jan 7, 2022

@code-asher recently patched #4598 in coder/vscode#34 (which we've had for a while but lost in a vscode upgrade).

We noticed this issue exists upstream in Codespaces, VS Code Web and have discussed extracting our patch and submitting a PR upstream.

The extraction will require some tweaking, but hoping it's not too difficult.

Related

Activity

  1. jsjoeio
    added
    featureNew user visible feature
    on Jan 7, 2022
  2. jsjoeio
    added this to the 4.0.2 milestone on Jan 7, 2022
  3. jsjoeio
    self-assigned this
    on Jan 18, 2022
  4. code-asher
    modified the milestones: 4.0.2, 4.0.3 on Jan 27, 2022
  5. jsjoeio
    modified the milestones: 4.0.3, On Deck on Feb 1, 2022
  6. jsjoeio
    modified the milestones: On Deck, March 2022 on Mar 3, 2022
  7. jsjoeio
    modified the milestones: March 2022, April 2022 on Mar 22, 2022
  8. jsjoeio
    modified the milestones: April 2022, May 2022 on Apr 26, 2022

  9. jsjoeio commented on Jun 15, 2022

    @jsjoeio
    jsjoeio
    on Jun 15, 2022
    ContributorAuthor

    They ended up going with a different approach. See microsoft/vscode#146012 (comment)

  10. jsjoeio
    closed this as not plannedon Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

featureNew user visible feature

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions