Skip to content

Patch configuring the display language  #4598

Closed

Description

@jsjoeio

Previously, we supported the ability to configure the Display Language. As a result of switching to VS Code's upstream server, we have lost this feature with the 4.0.0 upgrade.

Does it work upstream?

Apparently, no. If you go to vscode.dev and try to install a language pack, you get the following error messages:
image

Same with Codespaces
image

How did it work before in code-server?

I believe we had to patch it to get it to work. We can investigate readding the patch, or even submitting a patch upstream to get this functionality both in code-server and vscode.dev/Codespaces

Activity

  1. added this to the 4.0.1 milestone on Dec 9, 2021
  2. jsjoeio commented on Dec 13, 2021

    @jsjoeio
    ContributorAuthor

    Didn't mean to close this!

  3. modified the milestones: 4.0.1, 4.0.0 on Dec 13, 2021
  4. self-assigned this
    on Dec 13, 2021
  5. added
    bugSomething isn't working
    and removed
    enhancementSome improvement that isn't a feature
    on Dec 17, 2021
  6. jsjoeio commented on Dec 17, 2021

    @jsjoeio
    ContributorAuthor

    We used to patch this before. @code-asher patched this previously and will push up his patch. That's a good place to look. It will be on his fork here.

  7. code-asher commented on Dec 17, 2021

    @code-asher
    Member

    Linked above, note that you need to make a full build to test.

  8. added a commit that references this issue on Dec 23, 2021
  9. jsjoeio commented on Jan 3, 2022

    @jsjoeio
    ContributorAuthor

    Fixed via coder/vscode#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions