Skip to content

Handle non-executable tmp directory #1102

Closed

Description

@code-asher

It seems some hosting services mount /tmp without execute permissions which means search won't work since we extract and execute rg from there. We could try /tmp, the binary's directory, and then the system-installed rg if it exists in that order (possibly we'll want to ensure it's at least a certain version---I don't think VS Code makes any changes to ripgrep but we might want to double-check). If all fail we should output a message explaining that search won't work and how to fix it.

Activity

  1. deansheather commented on Oct 24, 2019

    @deansheather
    Collaborator

    It might be better to use $XDG_CACHE_HOME or $HOME/.cache instead of /tmp. Golang stdlib does a pretty good job of finding cache dir so I guess you could just copy that

  2. code-asher commented on Oct 24, 2019

    @code-asher
    MemberAuthor

    Ahh good point, I like that.

  3. Succubussix commented on Oct 24, 2019

    @Succubussix

    +1 for this.

    I have a dream that I can install this easily as 123 on all of my clients with their own jailed account + to avoid rebuilding it manually on each account... so all their extensions, config and stuff won't mix by others...

  4. nhooyr commented on Jan 29, 2020

    @nhooyr
    Contributor

    Related #1287

    This should be fixed anyway by Asher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSome improvement that isn't a feature

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions