Skip to content

parse_gctx: don't sort returned values #36

Open

Description

@dllahr

Hi @oena @levlitichev

I was thinking about doing a pull request where I modified parse_gctx to not return the dataframes sorted by index/column. The reason I propose this is if you read them out and get them in the order that they appear in the file, you can then choose the ones you are interested in, figure out their index id, and then use the ridx/cidx option to load them, which is much faster.

Also, could make it an option to do the sort. What do you think?

Activity

  1. oena commented on Apr 2, 2018

    @oena
    Contributor

    Hi @dllahr! Not sure I totally follow. Do you mean just for the metadata only options? Otherwise the IDs are subsetted before hyperslab selection occurs.

  2. dllahr commented on Apr 9, 2018

    @dllahr
    ContributorAuthor

    Sorry, no I mean that right now when you get the metadata back (and I think when you get it all back) all of the ID's have been sorted. The use-case I ran into was:

    1. got just the row metadata back
    2. identified the overlap between the genes I wanted an those that were present
    3. identified the indices of the genes I wanted in the row metadata
    4. attempted to load using the ridx option, got a completely different set of genes
    5. realized that the row metadata had been sorted, rather than returned as it appears in the file
  3. oena commented on Apr 9, 2018

    @oena
    Contributor

    Ok, gotcha. That does seem like a useful thing to do. Maybe we can start with having it as an option and see how things go?

  4. saksham219 commented on Jun 1, 2019

    @saksham219
    Contributor

    @oena Has this been taken up? I was thinking of working on this.

  5. oena commented on Jun 3, 2019

    @oena
    Contributor

    @dllahr did you follow up on this? No worries if not, just checking

  6. added a commit that references this issue on Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions