Skip to content

Issue #36 (add sort option for parse gctx) - #58

Merged
tnat1031 merged 18 commits into
cmap:masterfrom
saksham219:issue_36
Nov 8, 2019
Merged

tnat1031 merged 18 commits into
cmap:masterfrom
saksham219:issue_36

Conversation

@saksham219

@saksham219 saksham219 commented Jun 23, 2019 •

Copy link
Copy Markdown
Contributor

parse_gctx() function uses h5py to parse gctx files. h5py only takes indexes in a sorted order. To subset gctx files in the order indicated by the user, I have made some modifications to parse_gctx and associated functions to sort the dataframes returned by h5py according to the order indicated in the function call.

Other changes

  • added new test cases to test_parse_gctx (both python2 and python3) to test for cases where sorting is set to False.
  • absolute paths for example gct files in test cases and addition of init.py to test case directories so that all test cases can be run from one place in editors.
  • function documentation changes.
  • less complicated travis config

@saksham219 saksham219 changed the title Issue 36(add sort option for parse gctx) Issue #36(add sort option for parse gctx) Jun 23, 2019
@saksham219 saksham219 changed the title Issue #36(add sort option for parse gctx) Issue #36 (add sort option for parse gctx) Jun 23, 2019
@tnat1031
tnat1031 merged commit 28817ff into cmap:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants