Repository navigation
fix(fields): one asset check, translations respect per-field localization - #100
Merged
Merged
Conversation
…tion - Field asset rules (an image field needs an image of this site, rich-text asset: references must exist, a retired file is not newly used) live once in @cloudhal/core-ts/media (fieldAssetIssues, with a lookup function); the store and the MCP precheck share it, so MCP no longer refuses writes the store accepts. - RFC-0041 §5: get_translation_source returns only the localized text and rich-text values plus the shared keys; save_translation takes fields and refuses non-localized ones in precheck (field_not_localized); a new translation no longer copies field values. Studio's hand-written draft copies only localized values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups from RFC-0041 (#95, #97).
1. One field-asset check
fieldAssetIssues({defs, refs, kept, lookup, skip?})in@cloudhal/core-ts/media. It takes a lookup function, so it doesn't touch storage.asset:references must exist, and a retired file can't be newly used. The codes and messages are the same as before.planEntryFields), the store'sdiagnose, and the MCP precheck. The copy in mcp-server is deleted.2. RFC-0041 §5 in the translation tools
get_translation_source:sourceno longer carriesfields. A newfieldsoutput holds only the localized text and rich-text values to translate, and a newsharedFieldsoutput lists the non-localized keys. Glossary matching includes the field values.save_translation:fieldsinput. Non-localized values are refused in precheck withfield_not_localized, with paths indetails.issues, before anything is written.Tests
EADDRNOTAVAIL.Changeset: patch (
core-ts,mcp-server).🤖 Generated with Claude Code