Repository navigation
chore: release 4.0.0 - #341
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
force-pushed
the
release-v4.0.0
branch
2 times, most recently
from
October 1, 2020 15:43
f40c50e to
4243137
Compare
github-actions
Bot
force-pushed
the
release-v4.0.0
branch
from
October 1, 2020 19:13
4243137 to
d6e0da1
Compare
Member
|
@lholmquist something seems wrong with the changelog here. It should not have all of these commits. Locally, when I try to see what has changed between v3.2.0 and HEAD, I see this. ❯ git log b9ed2619c0362390c221e9bf8bf61deea7bd83fd..HEAD --oneline
e334b6e (HEAD -> main, origin/main) feat: add emitterFactory and friends (#342)
a9114b7 chore: add an automated GH action for releases (#329)
eca43d9 fix: package.json & package-lock.json to reduce vulnerabilities (#338)
0a12146 docs: update README with maintainer names (#337)
1fa3a05 feat: add a constructor parameter for loose validation (#328)
7423acb fix: upgrade cloudevents from 3.0.1 to 3.1.0 (#335)
4779d89 chore(example): Replaced body parser with express JSON parser (#334)
6cd310c src(event)!: make the event's time property only a string (#330)
f3953a9 (v3.2.x) feat: introduce Message, Serializer, Deserializer and Binding interfaces (#324)
17d4bc8 chore: add cucumber.js to list of files to lint and /docs to .gitignore (#327)
73f0bec chore: Update README with correct links for the support specification versions (#321)
0adcc35 chore: Remove commented version import. (#319)
6e2390e fix: upgrade uuid from 8.2.0 to 8.3.0 (#317)
4bf2eb8 chore: Update references of master to main (#316)
b5cf886 test: implement pending tests leftover from TS rewrite (#315)
8ac3eb0 refactor: validate cloudevent version agnostic (#311)
81623ac chore: typo (#313)
b3624c2 docs: add ref to CoC and other things (#244)However, the output from the GH Action shows this - 585 commits since b9ed261. Run GoogleCloudPlatform/release-please-action@v2.4.1
✖ no recent release PRs found
✔ found 585 commits since b9ed2619c0362390c221e9bf8bf61deea7bd83fd
✔ release as major: There are 9 BREAKING CHANGES and 12 features
✔ updating package-lock.json from 3.1.0 to 4.0.0
✖ file samples/package.json did not exist
✔ updating CHANGELOG.md
✔ updating package.json from 3.1.0 to 4.0.0
✔ update pull-request #341: chore: release 4.0.0
✔ adding label autorelease: pending to https://github.com/cloudevents/sdk-javascript/pull/341
✔ cloudevents/sdk-javascript find stale PRs with label "autorelease: pending" |
Member
|
I have opened an issue upstream to look into this. |
Contributor
|
I wonder if we should close this PR then rerun the action now that we’ve
updated the release-please action
…Sent from my iPhone
On Oct 1, 2020, at 3:45 PM, Lance Ball <notifications@github.com> wrote:
I have opened an issue upstream
<googleapis/release-please-action#78> to
look into this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#341 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5GUQ3QKXUODC4WOFJV33SITL6RANCNFSM4RQZTZUA>
.
|
Member
At the risk of making things worse... I'm going to try this. |
Member
|
Closing to see if we can't get the action to work properly now that we've updated the release-please-action version. |
Member
|
Updated PR is the same #348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release *beep* *boop*
4.0.0 (2020-10-01)
⚠ BREAKING CHANGES
Features
Bug Fixes
lib
Tests
Miscellaneous
Documentation
This PR was generated with Release Please.