Repository navigation
src(event)!: make the event's time property only a string - #330
Merged
Merged
Conversation
Previously, the event's `time` property could be either a string or a date. this commit modifies that to ensure that the object can only be created with a timestamp in string format. As long as the string is a valid date, that can be parsed by `new Date(Date.parse(str))` then whenever the event is serialized as JSON, the `time` attribute will be formatted as per RFC 3339. Fixes: cloudevents#326 Signed-off-by: Lance Ball <lball@redhat.com>
lance
added
type/enhancement
Closed
This was referenced Sep 27, 2020
Closed
Closed
This was referenced Oct 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
event.timealways produces the value provided in the constructornew Date().toString()works with event attribute validationDateParserwhich processes an incoming binary event Message'sce-timeheader andtimeproperty for a structured eventMessage.Description
Previously, the event's
timeproperty could be either a string or a date.this commit modifies that to ensure that the object can only be created with
a timestamp in string format. As long as the string is a valid date, that
can be parsed by
new Date(Date.parse(str))then whenever the event isserialized as JSON, the
timeattribute will be formatted as per RFC 3339.BREAKING CHANGE
Signed-off-by: Lance Ball lball@redhat.com