Repository navigation
lib: validate extension values - #251
Merged
lholmquist merged 5 commits intoJul 27, 2020
Merged
Conversation
lholmquist
force-pushed
the
229-validate-ext-values
branch
from
July 15, 2020 14:02
05362bf to
7bbb303
Compare
lance
added
module/lib
Member
|
@lholmquist I wonder if we actually need to check for URI. There is no defined URI type in JavaScript, so the actual representation will always be a string. And I don't think we need to be parsing strings to determine if they are a URI. Maybe this can just land as is. What do you think? |
Contributor
Author
|
@lance that sounds good to me. The only thing i could think was that we could create a new |
lholmquist
marked this pull request as ready for review
July 23, 2020 20:58
lholmquist
requested review from
a team,
danbev,
helio-frota and
lance
and removed request for
a team
July 23, 2020 20:59
helio-frota
approved these changes
Jul 23, 2020
lholmquist
force-pushed
the
229-validate-ext-values
branch
from
July 24, 2020 12:58
7bbb303 to
59104d6
Compare
lance
approved these changes
Jul 24, 2020
lance
left a comment
lance
left a comment
Member
There was a problem hiding this comment.
A single, very minor nit re: spelling in a comment (am I just too picky!?) 😄
Closed
lholmquist
marked this pull request as draft
July 24, 2020 19:14
lholmquist
force-pushed
the
229-validate-ext-values
branch
from
July 24, 2020 19:18
e075d3a to
194cdf3
Compare
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
lholmquist
force-pushed
the
229-validate-ext-values
branch
from
July 24, 2020 19:38
4365f47 to
c3f8e92
Compare
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
lholmquist
marked this pull request as ready for review
July 27, 2020 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This validates the value of the cloud event extension based on the spec, https://github.com/cloudevents/spec/blob/master/spec.md#type-system
I still need to add a check for the value being a URI
fixes #229