CloudEvent extensions should be restricted to types allowed in spec #229

Activity

1. lance

   added

   type/bugSomething isn't workingSomething isn't working

   spec/1.0Issues related to the CE specificationIssues related to the CE specification

   on Jun 20, 2020
2. lholmquist

   added

   version/3.xIssues related to the 3.0 release of this libraryIssues related to the 3.0 release of this library

   on Jul 8, 2020
3. lholmquist commented on Jul 8, 2020

   

   lholmquist

   on Jul 8, 2020

   Last edited by lholmquist

   Contributor

   More actions

   Since the spec doesn't allow an Object, should we be throwing an error if someone passes in this:

   new CloudEvent({
   ...
   ...
   extension1: { key: value }
   })
   

   Or is this ok since it will get converted to a JSON before transmission. basically, should this test pass or fail: https://github.com/cloudevents/sdk-javascript/blob/master/test/integration/spec_1_tests.ts#L99
4. lance commented on Jul 13, 2020

   

   lance

   on Jul 13, 2020

   MemberAuthor

   More actions

   That test should probably fail. We can't assume that the receiver will know that the value needs to be converted to an object. Since strings are valid value types, the user should use JSON.stringify before setting the extension.

   👍React with 👍1Reacted by Lucas Holmquist
5. lholmquist

   closed this as completedin #251on Jul 27, 2020